# [PATCH] use isxdigit() for checking if a character is a hexadecimal digit

1 messages from 2015-03-09 to 2015-03-09. Participants: René Scharfe.
Thread: https://gitlist.dev/t/38769

## René Scharfe, 2015-03-09 22:46

Subject: [PATCH] use isxdigit() for checking if a character is a hexadecimal digit
Message-ID: <54FE22DE.8090007@web.de>
URL: https://gitlist.dev/e/54FE22DE.8090007%40web.de

```
Use the standard function isxdigit() to make the intent clearer and
avoid using magic constants.

Signed-off-by: Rene Scharfe <l.s.r@web.de>
---
 sha1_name.c | 2 +-
 transport.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/sha1_name.c b/sha1_name.c
index 95f9f8f..6d10f05 100644
--- a/sha1_name.c
+++ b/sha1_name.c
@@ -757,7 +757,7 @@ static int get_describe_name(const char *name, int len, unsigned char *sha1)
 
 	for (cp = name + len - 1; name + 2 <= cp; cp--) {
 		char ch = *cp;
-		if (hexval(ch) & ~0377) {
+		if (!isxdigit(ch)) {
 			/* We must be looking at g in "SOMETHING-g"
 			 * for it to be describe output.
 			 */
diff --git a/transport.c b/transport.c
index 0694a7c..00f39d9 100644
--- a/transport.c
+++ b/transport.c
@@ -117,7 +117,7 @@ static void insert_packed_refs(const char *packed_refs, struct ref **list)
 			return;
 		}
 
-		if (hexval(buffer[0]) > 0xf)
+		if (!isxdigit(buffer[0]))
 			continue;
 		len = strlen(buffer);
 		if (len && buffer[len - 1] == '\n')
-- 
2.3.1

```