threads / patch / 38717

patchfor the SoC15 micro project, Make "git -C '' cmd" not to barf.

Subject: [PATCH] for the SoC15 micro project, Make "git -C '' cmd" not to barf.

## tl;dr

3 messages between Mar 6, 2015 and Mar 6, 2015. Diffs are folded; open one to read it.

replies: 2people: 3as markdown or json

Prudhvee Narasimha Sadha· Mar 6, 2015, 01:46 UTC · lore

Hi,
    here is my patch for the micro project, Please review the code.

prudh@prudh-Studio-1569:~/git$ git diff

Show changes to git.c +2 −0

diff --git a/git.c b/git.c
index 8c7ee9c..364788b 100644
--- a/git.c
+++ b/git.c
@@ -205,6 +205,8 @@ static int handle_options(const char ***argv, int *argc, int
                                usage(git_usage_string);
                        }
                        if (chdir((*argv)[1]))
+                               if(*(*argv)[1]==0);
+                       else if(chdir((*argv)[1]))
                                die_errno("Cannot change to '%s'", (*argv)[1]);
                        if (envchanged)
                                *envchanged = 1;




Thank you,
Prudhvee

Stefan Beller· Mar 6, 2015, 01:58 UTC · re: Prudhvee Narasimha Sadha · lore

Re: [PATCH] for the SoC15 micro project, Make "git -C '' cmd" not to barf.

On Thu, Mar 5, 2015 at 5:46 PM, Prudhvee Narasimha Sadha <prudhvi.sada@gmail.com> wrote:

Show 5 quoted lines

> Hi,
>     here is my patch for the micro project, Please review the code.
>
>
> prudh@prudh-Studio-1569:~/git$ git diff

Please see Documentation/SubmittingPatches and maybe have a look at the format-patch manpage.

Thanks, Stefan

Show 23 quoted lines

> diff --git a/git.c b/git.c
> index 8c7ee9c..364788b 100644
> --- a/git.c
> +++ b/git.c
> @@ -205,6 +205,8 @@ static int handle_options(const char ***argv, int *argc, int
>                                 usage(git_usage_string);
>                         }
>                         if (chdir((*argv)[1]))
> +                               if(*(*argv)[1]==0);
> +                       else if(chdir((*argv)[1]))
>                                 die_errno("Cannot change to '%s'", (*argv)[1]);
>                         if (envchanged)
>                                 *envchanged = 1;
>
>
>
>
> Thank you,
> Prudhvee
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Matthieu Moy· Mar 6, 2015, 11:54 UTC · re: Prudhvee Narasimha Sadha · lore

Re: [PATCH] for the SoC15 micro project, Make "git -C '' cmd" not to barf.

Prudhvee Narasimha Sadha <prudhvi.sada@gmail.com> writes:

> Hi,
>     here is my patch for the micro project, Please review the code.

Please, read Documentation/SubmittingPatches.

Also, read the comments on the other submission for the same problem on the list, they also apply to your version.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/