# [PATCH] git: make "git -C '' <cmd>" not to barf

4 messages from 2015-03-03 to 2015-03-04. Participants: Karthik Nayak, Matthieu Moy, Junio C Hamano.
Thread: https://gitlist.dev/t/38689

## Karthik Nayak, 2015-03-03 15:41

Subject: [PATCH] git: make "git -C '' <cmd>" not to barf
Message-ID: <1425397291-25435-1-git-send-email-karthik.188@gmail.com>
URL: https://gitlist.dev/e/1425397291-25435-1-git-send-email-karthik.188%40gmail.com

```
now it works like cd "" which silently succeeds

Signed-off-by: Karthik Nayak <karthik.188@gmail.com>
---
 git.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/git.c b/git.c
index 8c7ee9c..f4c2285 100644
--- a/git.c
+++ b/git.c
@@ -204,7 +204,9 @@ static int handle_options(const char ***argv, int *argc, int *envchanged)
 				fprintf(stderr, "No directory given for -C.\n" );
 				usage(git_usage_string);
 			}
-			if (chdir((*argv)[1]))
+			if (*(*argv)[1] == 0)
+				; /* Ignore "" as a directory */
+			else if (chdir((*argv)[1]))
 				die_errno("Cannot change to '%s'", (*argv)[1]);
 			if (envchanged)
 				*envchanged = 1;
-- 
2.3.1.167.g7f4ba4b.dirty

```

## Matthieu Moy, 2015-03-03 16:22

Subject: Re: [PATCH] git: make "git -C '' <cmd>" not to barf
Message-ID: <vpq385mgifi.fsf@anie.imag.fr>
URL: https://gitlist.dev/e/vpq385mgifi.fsf%40anie.imag.fr
In-Reply-To: <1425397291-25435-1-git-send-email-karthik.188@gmail.com>

```
Karthik Nayak <karthik.188@gmail.com> writes:

> now it works like cd "" which silently succeeds

Missing "." at end of sentence.

>  git.c | 4 +++-

That would probably also deserve a test.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/

```

## Junio C Hamano, 2015-03-03 18:00

Subject: Re: [PATCH] git: make "git -C '' <cmd>" not to barf
Message-ID: <CAPc5daWFAV2P_MCCo=oz2Be=2_L5NVxNweY+rUbU5OcK84wVaQ@mail.gmail.com>
URL: https://gitlist.dev/e/CAPc5daWFAV2P_MCCo%3Doz2Be%3D2_L5NVxNweY%2BrUbU5OcK84wVaQ%40mail.gmail.com
In-Reply-To: <vpq385mgifi.fsf@anie.imag.fr>

```
On Tue, Mar 3, 2015 at 8:22 AM, Matthieu Moy
<Matthieu.Moy@grenoble-inp.fr> wrote:
> Karthik Nayak <karthik.188@gmail.com> writes:
>
>> now it works like cd "" which silently succeeds
>
> Missing "." at end of sentence.

And lack of capitalization at the beginning.

More importantly, lack of justification--why is it a good idea to make
"it works like cd ''" in the first place?

>
>>  git.c | 4 +++-
>
> That would probably also deserve a test.

Another "huh?" I had on the actual code was if this counts as "envchanged", if
you are not actually changing the directory at all.

Is this meant as a "micro" for GSoC, by the way?

```

## Karthik Nayak, 2015-03-04 08:41

Subject: Re: [PATCH] git: make "git -C '' <cmd>" not to barf
Message-ID: <E3F15B02-CDDA-473C-86D0-2A337FBDF185@gmail.com>
URL: https://gitlist.dev/e/E3F15B02-CDDA-473C-86D0-2A337FBDF185%40gmail.com
In-Reply-To: <CAPc5daWFAV2P_MCCo=oz2Be=2_L5NVxNweY+rUbU5OcK84wVaQ@mail.gmail.com>

```


On March 3, 2015 11:30:13 PM GMT+05:30, Junio C Hamano <gitster@pobox.com> wrote:
>On Tue, Mar 3, 2015 at 8:22 AM, Matthieu Moy
><Matthieu.Moy@grenoble-inp.fr> wrote:
>> Karthik Nayak <karthik.188@gmail.com> writes:
>>
>>> now it works like cd "" which silently succeeds
>>
>> Missing "." at end of sentence.
>
>And lack of capitalization at the beginning.
Yes, noted, Will fix with next patch.
>
>More importantly, lack of justification--why is it a good idea to make
>"it works like cd ''" in the first place?
>
>>
>>>  git.c | 4 +++-
>>
>> That would probably also deserve a test.
Will include a patch with next patch version.
>
>Another "huh?" I had on the actual code was if this counts as
>"envchanged", if
>you are not actually changing the directory at all.
>
>Is this meant as a "micro" for GSoC, by the way?
Yes, it's meant for GSoC.
I did overlook that. Will fix in next patch version. 
Thanks for your suggestions

```