threads / discuss / 38685

git notes from incoming patch

Subject: git notes from incoming patch

## tl;dr

3 messages between Mar 3, 2015 and Mar 3, 2015.

replies: 2people: 2as markdown or json

Keller, Jacob E· Mar 3, 2015, 01:32 UTC · lore

Hi,

I am wondering whether it is possible to read from a format-patch input and add notes when we generate the applied patch.

The use case is to be able to send patches that had notes appended via

$git format-patch --notes ...

And have notes objects created on the remote repository to store this information.

Is there any way to do this? and/or is there a way to get the same results that maybe doesn't use notes?

The problem we are trying to solve is a way to track some information about a patch that we need internally without submitting it upstream when we submit the patches later. We use email to handle internal patch queues, so essentially we want to be able to add note objects to the format-patch and send them via email.

Regards, Jake

Junio C Hamano· Mar 3, 2015, 20:14 UTC · re: Keller, Jacob E · lore

Re: git notes from incoming patch

"Keller, Jacob E" <jacob.e.keller@intel.com> writes:

> I am wondering whether it is possible to read from a format-patch input
> and add notes when we generate the applied patch.

I would think post-applypatch hook is the right place to do this. The hook has access to the incoming message in $GIT_DIR/rebase-apply directory ('next' records the message number in the series, and then you have individual pieces of e-mails separated out into 0001, 0002, etc. you can read from), and "HEAD" already points at the result of applying the patch.

Peek 'post-applypatch' on my 'todo' branch for inspirations.

Keller, Jacob E· Mar 3, 2015, 21:08 UTC · re: Junio C Hamano · lore

RE: git notes from incoming patch

Show 20 quoted lines

> -----Original Message-----
> From: Junio C Hamano [mailto:gitster@pobox.com]
> Sent: Tuesday, March 03, 2015 12:14 PM
> To: Keller, Jacob E
> Cc: git@vger.kernel.org
> Subject: Re: git notes from incoming patch
> 
> "Keller, Jacob E" <jacob.e.keller@intel.com> writes:
> 
> > I am wondering whether it is possible to read from a format-patch input
> > and add notes when we generate the applied patch.
> 
> I would think post-applypatch hook is the right place to do this.
> The hook has access to the incoming message in $GIT_DIR/rebase-apply
> directory ('next' records the message number in the series, and then
> you have individual pieces of e-mails separated out into 0001, 0002,
> etc. you can read from), and "HEAD" already points at the result of
> applying the patch.
> 
> Peek 'post-applypatch' on my 'todo' branch for inspirations.

Excellent, I will investigate this.

Regards, Jake