# [PATCH] connect: use strcmp() for string comparison

1 messages from 2015-02-21 to 2015-02-21. Participants: René Scharfe.
Thread: https://gitlist.dev/t/38624

## René Scharfe, 2015-02-21 19:49

Subject: [PATCH] connect: use strcmp() for string comparison
Message-ID: <54E8E166.7070500@web.de>
URL: https://gitlist.dev/e/54E8E166.7070500%40web.de

```
Get rid of magic string length constants and simply compare the strings
using strcmp().  This makes the intent of the code a bit clearer.

Signed-off-by: Rene Scharfe <l.s.r@web.de>
---
 connect.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/connect.c b/connect.c
index 062e133..2a5c400 100644
--- a/connect.c
+++ b/connect.c
@@ -157,8 +157,7 @@ struct ref **get_remote_heads(int in, char *src_buf, size_t src_len,
 			server_capabilities = xstrdup(name + name_len + 1);
 		}
 
-		if (extra_have &&
-		    name_len == 5 && !memcmp(".have", name, 5)) {
+		if (extra_have && !strcmp(name, ".have")) {
 			sha1_array_append(extra_have, old_sha1);
 			continue;
 		}
-- 
2.3.0

```