# [cosmetic bug?] needlessly(?) executable files 5 messages from 2015-02-21 to 2015-02-23. Participants: Christoph Anton Mitterer, Junio C Hamano, Dennis Kaarsemaker. Thread: https://gitlist.dev/t/38621 ## Christoph Anton Mitterer, 2015-02-21 17:48 Subject: [cosmetic bug?] needlessly(?) executable files Message-ID: <1424540917.15539.24.camel@scientia.net> URL: https://gitlist.dev/e/1424540917.15539.24.camel%40scientia.net ``` Hey. Just a question about files like: .git/config .git/hooks/*.sample Is there any reason that these are created executable? Especially the config file? I know the hooks are already disabled by being named .sample, but having them executable just increases the chance that one accidentally fires them up manually. Cheers, Chris. ``` ## Junio C Hamano, 2015-02-22 18:44 Subject: Re: [cosmetic bug?] needlessly(?) executable files Message-ID: URL: https://gitlist.dev/e/xmqqr3thwzur.fsf%40gitster.dls.corp.google.com In-Reply-To: <1424540917.15539.24.camel@scientia.net> ``` Christoph Anton Mitterer writes: > Just a question about files like: > .git/config > .git/hooks/*.sample > > Is there any reason that these are created executable? Especially the > config file? In a new repository I just did "git init", I see this: $ rm -fr stupid $ umask 0027 $ git init stupid $ ls -l stupid/.git/config | sed -e 's/ .*//' -rw-r----- So no, config is not created executable. > I know the hooks are already disabled by being named .sample, I think that is deliberate, so that lazy people can just do: $ mv .git/hooks/pre-commit.sample .git/hooks/pre-commit without one more command $ chmod +x .git/hooks/pre-commit after doing so. ``` ## Dennis Kaarsemaker, 2015-02-23 08:21 Subject: Re: [cosmetic bug?] needlessly(?) executable files Message-ID: <1424679663.30155.30.camel@kaarsemaker.net> URL: https://gitlist.dev/e/1424679663.30155.30.camel%40kaarsemaker.net In-Reply-To: ``` On zo, 2015-02-22 at 10:44 -0800, Junio C Hamano wrote: > Christoph Anton Mitterer writes: > > > Just a question about files like: > > .git/config > > .git/hooks/*.sample > > > > Is there any reason that these are created executable? Especially > the > > config file? > > In a new repository I just did "git init", I see this: > > $ rm -fr stupid > $ umask 0027 > $ git init stupid > $ ls -l stupid/.git/config | sed -e 's/ .*//' > -rw-r----- > > So no, config is not created executable. It used to be for a brief period in history, between daa22c6f8d (2.1.0) and 1f32ecf (2.2.2). -- Dennis Kaarsemaker http://www.kaarsemaker.net ``` ## Christoph Anton Mitterer, 2015-02-23 13:08 Subject: Re: [cosmetic bug?] needlessly(?) executable files Message-ID: <1424696893.4662.5.camel@scientia.net> URL: https://gitlist.dev/e/1424696893.4662.5.camel%40scientia.net In-Reply-To: <1424679663.30155.30.camel@kaarsemaker.net> ``` On Mon, 2015-02-23 at 09:21 +0100, Dennis Kaarsemaker wrote: > It used to be for a brief period in history, between daa22c6f8d (2.1.0) > and 1f32ecf (2.2.2). Ah thanks,... I have 2.1.4 which explains this :) Cheers, Chris. ``` ## Junio C Hamano, 2015-02-23 18:55 Subject: Re: [cosmetic bug?] needlessly(?) executable files Message-ID: URL: https://gitlist.dev/e/xmqqoaoktq2q.fsf%40gitster.dls.corp.google.com In-Reply-To: <1424679663.30155.30.camel@kaarsemaker.net> ``` Dennis Kaarsemaker writes: > On zo, 2015-02-22 at 10:44 -0800, Junio C Hamano wrote: >> Christoph Anton Mitterer writes: >> >> > Just a question about files like: >> > .git/config >> > .git/hooks/*.sample >> > >> > Is there any reason that these are created executable? Especially >> the >> > config file? >> >> In a new repository I just did "git init", I see this: >> >> $ rm -fr stupid >> $ umask 0027 >> $ git init stupid >> $ ls -l stupid/.git/config | sed -e 's/ .*//' >> -rw-r----- >> >> So no, config is not created executable. > > It used to be for a brief period in history, between daa22c6f8d (2.1.0) > and 1f32ecf (2.2.2). Ahh, yes, I think we fixed that bug not too long ago. Thanks for reminding me. ```