threads / patch / 38462

patchINSTALL: minor typo fix

Subject: [PATCH] INSTALL: minor typo fix

## tl;dr

4 messages between Jan 27, 2015 and Jan 27, 2015. Diffs are folded; open one to read it.

replies: 3people: 3as markdown or json

Alexander Kuleshov· Jan 27, 2015, 16:15 UTC · lore
Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
---
 INSTALL | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Show changes to INSTALL +1 −1
diff --git a/INSTALL b/INSTALL
index ffb071e..6f1c3d5 100644
--- a/INSTALL
+++ b/INSTALL
@@ -53,7 +53,7 @@ or
 
 As a caveat: a profile-optimized build takes a *lot* longer since the
 git tree must be built twice, and in order for the profiling
-measurements to work properly, ccache must be disabled and the test
+measurements to work properly, cache must be disabled and the test
 suite has to be run using only a single CPU.  In addition, the profile
 feedback build stage currently generates a lot of additional compiler
 warnings.
-- 
2.3.0-rc1
Chris Packham· Jan 27, 2015, 17:09 UTC · re: Alexander Kuleshov · lore

Re: [PATCH] INSTALL: minor typo fix

Hi Alexander

On Wed, Jan 28, 2015 at 5:15 AM, Alexander Kuleshov <kuleshovmail@gmail.com> wrote:

Show 19 quoted lines
> Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
> ---
>  INSTALL | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/INSTALL b/INSTALL
> index ffb071e..6f1c3d5 100644
> --- a/INSTALL
> +++ b/INSTALL
> @@ -53,7 +53,7 @@ or
>
>  As a caveat: a profile-optimized build takes a *lot* longer since the
>  git tree must be built twice, and in order for the profiling
> -measurements to work properly, ccache must be disabled and the test
> +measurements to work properly, cache must be disabled and the test
>  suite has to be run using only a single CPU.  In addition, the profile
>  feedback build stage currently generates a lot of additional compiler
>  warnings.
> --

That's not a typo ccache[1] is a compiler cache tool that can be used to speed up rebuilding object files. I don't know anything about the profile enabled builds but I imagine it has something to do with needing the 2nd build to produce difference object files from the first (with ccache enabled I imagine the 2nd build would result in identical output since on source files are changed between builds).

-- [1] - https://ccache.samba.org/

Chris Packham· Jan 27, 2015, 17:15 UTC · re: Chris Packham · lore

Re: [PATCH] INSTALL: minor typo fix

On Wed, Jan 28, 2015 at 6:09 AM, Chris Packham <judge.packham@gmail.com> wrote:
Show 28 quoted lines
> Hi Alexander
>
> On Wed, Jan 28, 2015 at 5:15 AM, Alexander Kuleshov
> <kuleshovmail@gmail.com> wrote:
>> Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
>> ---
>>  INSTALL | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/INSTALL b/INSTALL
>> index ffb071e..6f1c3d5 100644
>> --- a/INSTALL
>> +++ b/INSTALL
>> @@ -53,7 +53,7 @@ or
>>
>>  As a caveat: a profile-optimized build takes a *lot* longer since the
>>  git tree must be built twice, and in order for the profiling
>> -measurements to work properly, ccache must be disabled and the test
>> +measurements to work properly, cache must be disabled and the test
>>  suite has to be run using only a single CPU.  In addition, the profile
>>  feedback build stage currently generates a lot of additional compiler
>>  warnings.
>> --
>
> That's not a typo ccache[1] is a compiler cache tool that can be used
> to speed up rebuilding object files. I don't know anything about the
> profile enabled builds but I imagine it has something to do with
> needing the 2nd build to produce difference object files from the
s/difference/different/
Show 5 quoted lines
> first (with ccache enabled I imagine the 2nd build would result in
> identical output since on source files are changed between builds).
>
> --
> [1] - https://ccache.samba.org/

The commit that added that note f2d713fc[1] has a bit more of an explanation of why profile enabled builds and ccache are incompatible.

[1] - https://github.com/git/git/commit/f2d713fc3e8e0b7be89584f04b421808aa99c403
Jeff King· Jan 27, 2015, 17:17 UTC · re: Chris Packham · lore

Re: [PATCH] INSTALL: minor typo fix

On Wed, Jan 28, 2015 at 06:09:52AM +1300, Chris Packham wrote:
Show 28 quoted lines
> On Wed, Jan 28, 2015 at 5:15 AM, Alexander Kuleshov
> <kuleshovmail@gmail.com> wrote:
> > Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
> > ---
> >  INSTALL | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/INSTALL b/INSTALL
> > index ffb071e..6f1c3d5 100644
> > --- a/INSTALL
> > +++ b/INSTALL
> > @@ -53,7 +53,7 @@ or
> >
> >  As a caveat: a profile-optimized build takes a *lot* longer since the
> >  git tree must be built twice, and in order for the profiling
> > -measurements to work properly, ccache must be disabled and the test
> > +measurements to work properly, cache must be disabled and the test
> >  suite has to be run using only a single CPU.  In addition, the profile
> >  feedback build stage currently generates a lot of additional compiler
> >  warnings.
> > --
> 
> That's not a typo ccache[1] is a compiler cache tool that can be used
> to speed up rebuilding object files. I don't know anything about the
> profile enabled builds but I imagine it has something to do with
> needing the 2nd build to produce difference object files from the
> first (with ccache enabled I imagine the 2nd build would result in
> identical output since on source files are changed between builds).

Yes, ccache creates a cache key for each file based on the command line flags to the compiler, and the output of the pre-processor when run on the file. The profiling data generated by the first run is outside of what ccache knows about, so it can't include that information in its cache key (and consequently, we get false cache hits).

So yeah. Not a typo.
-Peff

← back to recent threads