# [PATCH] git-gui: sort entries in tclIndex 6 messages from 2015-01-26 to 2015-10-05. Participants: Olaf Hering, René Scharfe, Pat Thoyts. Thread: https://gitlist.dev/t/38454 ## Olaf Hering, 2015-01-26 17:07 Subject: [PATCH] git-gui: sort entries in tclIndex Message-ID: <1422292043-12711-1-git-send-email-olaf@aepfle.de> URL: https://gitlist.dev/e/1422292043-12711-1-git-send-email-olaf%40aepfle.de ``` ALL_LIBFILES uses wildcard, which provides the result in directory order. This order depends on the underlying filesystem on the buildhost. To get reproducible builds it is required to sort such list before using them. Signed-off-by: Olaf Hering --- git-gui/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/git-gui/Makefile b/git-gui/Makefile index cde8b2e..7564a18 100644 --- a/git-gui/Makefile +++ b/git-gui/Makefile @@ -258,7 +258,7 @@ lib/tclIndex: $(ALL_LIBFILES) GIT-GUI-VARS rm -f $@ ; \ echo '# Autogenerated by git-gui Makefile' >$@ && \ echo >>$@ && \ - $(foreach p,$(PRELOAD_FILES) $(ALL_LIBFILES),echo '$(subst lib/,,$p)' >>$@ &&) \ + $(foreach p,$(PRELOAD_FILES) $(sort $(ALL_LIBFILES)),echo '$(subst lib/,,$p)' >>$@ &&) \ echo >>$@ ; \ fi ``` ## Olaf Hering, 2015-02-10 15:18 Subject: Re: [PATCH] git-gui: sort entries in tclIndex Message-ID: <20150210151803.GB8965@aepfle.de> URL: https://gitlist.dev/e/20150210151803.GB8965%40aepfle.de In-Reply-To: <1422292043-12711-1-git-send-email-olaf@aepfle.de> ``` Ping? On Mon, Jan 26, Olaf Hering wrote: > ALL_LIBFILES uses wildcard, which provides the result in directory > order. This order depends on the underlying filesystem on the > buildhost. To get reproducible builds it is required to sort such list > before using them. > > Signed-off-by: Olaf Hering > --- > git-gui/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/git-gui/Makefile b/git-gui/Makefile > index cde8b2e..7564a18 100644 > --- a/git-gui/Makefile > +++ b/git-gui/Makefile > @@ -258,7 +258,7 @@ lib/tclIndex: $(ALL_LIBFILES) GIT-GUI-VARS > rm -f $@ ; \ > echo '# Autogenerated by git-gui Makefile' >$@ && \ > echo >>$@ && \ > - $(foreach p,$(PRELOAD_FILES) $(ALL_LIBFILES),echo '$(subst lib/,,$p)' >>$@ &&) \ > + $(foreach p,$(PRELOAD_FILES) $(sort $(ALL_LIBFILES)),echo '$(subst lib/,,$p)' >>$@ &&) \ > echo >>$@ ; \ > fi > ``` ## Olaf Hering, 2015-04-15 07:22 Subject: Re: [PATCH] git-gui: sort entries in tclIndex Message-ID: <20150415072251.GA18595@aepfle.de> URL: https://gitlist.dev/e/20150415072251.GA18595%40aepfle.de In-Reply-To: <20150210151803.GB8965@aepfle.de> ``` Ping? On Tue, Feb 10, Olaf Hering wrote: > Ping? > > On Mon, Jan 26, Olaf Hering wrote: > > > ALL_LIBFILES uses wildcard, which provides the result in directory > > order. This order depends on the underlying filesystem on the > > buildhost. To get reproducible builds it is required to sort such list > > before using them. > > > > Signed-off-by: Olaf Hering > > --- > > git-gui/Makefile | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/git-gui/Makefile b/git-gui/Makefile > > index cde8b2e..7564a18 100644 > > --- a/git-gui/Makefile > > +++ b/git-gui/Makefile > > @@ -258,7 +258,7 @@ lib/tclIndex: $(ALL_LIBFILES) GIT-GUI-VARS > > rm -f $@ ; \ > > echo '# Autogenerated by git-gui Makefile' >$@ && \ > > echo >>$@ && \ > > - $(foreach p,$(PRELOAD_FILES) $(ALL_LIBFILES),echo '$(subst lib/,,$p)' >>$@ &&) \ > > + $(foreach p,$(PRELOAD_FILES) $(sort $(ALL_LIBFILES)),echo '$(subst lib/,,$p)' >>$@ &&) \ > > echo >>$@ ; \ > > fi > > ``` ## René Scharfe, 2015-04-25 16:27 Subject: Re: [PATCH] git-gui: sort entries in tclIndex Message-ID: <553BC05F.1070702@web.de> URL: https://gitlist.dev/e/553BC05F.1070702%40web.de In-Reply-To: <20150415072251.GA18595@aepfle.de> ``` Looping in Pat (git-gui maintainer). Am 15.04.2015 um 09:22 schrieb Olaf Hering: > Ping? > > On Tue, Feb 10, Olaf Hering wrote: > >> Ping? >> >> On Mon, Jan 26, Olaf Hering wrote: >> >>> ALL_LIBFILES uses wildcard, which provides the result in directory >>> order. This order depends on the underlying filesystem on the >>> buildhost. To get reproducible builds it is required to sort such list >>> before using them. >>> >>> Signed-off-by: Olaf Hering >>> --- >>> git-gui/Makefile | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/git-gui/Makefile b/git-gui/Makefile >>> index cde8b2e..7564a18 100644 >>> --- a/git-gui/Makefile >>> +++ b/git-gui/Makefile >>> @@ -258,7 +258,7 @@ lib/tclIndex: $(ALL_LIBFILES) GIT-GUI-VARS >>> rm -f $@ ; \ >>> echo '# Autogenerated by git-gui Makefile' >$@ && \ >>> echo >>$@ && \ >>> - $(foreach p,$(PRELOAD_FILES) $(ALL_LIBFILES),echo '$(subst lib/,,$p)' >>$@ &&) \ >>> + $(foreach p,$(PRELOAD_FILES) $(sort $(ALL_LIBFILES)),echo '$(subst lib/,,$p)' >>$@ &&) \ >>> echo >>$@ ; \ >>> fi >>> ``` ## Pat Thoyts, 2015-05-01 14:57 Subject: Re: [PATCH] git-gui: sort entries in tclIndex Message-ID: <87sibgpcpp.fsf@red.patthoyts.tk> URL: https://gitlist.dev/e/87sibgpcpp.fsf%40red.patthoyts.tk In-Reply-To: <553BC05F.1070702@web.de> ``` René Scharfe writes: >Looping in Pat (git-gui maintainer). > >Am 15.04.2015 um 09:22 schrieb Olaf Hering: >> Ping? >> >> On Tue, Feb 10, Olaf Hering wrote: >> >>> Ping? >>> >>> On Mon, Jan 26, Olaf Hering wrote: >>> >>>> ALL_LIBFILES uses wildcard, which provides the result in directory >>>> order. This order depends on the underlying filesystem on the >>>> buildhost. To get reproducible builds it is required to sort such list >>>> before using them. >>>> >>>> Signed-off-by: Olaf Hering >>>> --- >>>> git-gui/Makefile | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/git-gui/Makefile b/git-gui/Makefile >>>> index cde8b2e..7564a18 100644 >>>> --- a/git-gui/Makefile >>>> +++ b/git-gui/Makefile >>>> @@ -258,7 +258,7 @@ lib/tclIndex: $(ALL_LIBFILES) GIT-GUI-VARS >>>> rm -f $@ ; \ >>>> echo '# Autogenerated by git-gui Makefile' >$@ && \ >>>> echo >>$@ && \ >>>> - $(foreach p,$(PRELOAD_FILES) $(ALL_LIBFILES),echo '$(subst lib/,,$p)' >>$@ &&) \ >>>> + $(foreach p,$(PRELOAD_FILES) $(sort $(ALL_LIBFILES)),echo '$(subst lib/,,$p)' >>$@ &&) \ >>>> echo >>$@ ; \ >>>> fi >>>> > Applied. Thank you. -- Pat Thoyts http://www.patthoyts.tk/ PGP fingerprint 2C 6E 98 07 2C 59 C8 97 10 CE 11 E6 04 E0 B9 DD ``` ## Olaf Hering, 2015-10-05 07:43 Subject: Re: [PATCH] git-gui: sort entries in tclIndex Message-ID: <20151005074332.GA21840@aepfle.de> URL: https://gitlist.dev/e/20151005074332.GA21840%40aepfle.de In-Reply-To: <87sibgpcpp.fsf@red.patthoyts.tk> ``` To which branch was this applied? Its still broken in git-2.6.0. Olaf On Fri, May 01, Pat Thoyts wrote: > René Scharfe writes: > > >Looping in Pat (git-gui maintainer). > > > >Am 15.04.2015 um 09:22 schrieb Olaf Hering: > >> Ping? > >> > >> On Tue, Feb 10, Olaf Hering wrote: > >> > >>> Ping? > >>> > >>> On Mon, Jan 26, Olaf Hering wrote: > >>> > >>>> ALL_LIBFILES uses wildcard, which provides the result in directory > >>>> order. This order depends on the underlying filesystem on the > >>>> buildhost. To get reproducible builds it is required to sort such list > >>>> before using them. > >>>> > >>>> Signed-off-by: Olaf Hering > >>>> --- > >>>> git-gui/Makefile | 2 +- > >>>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>>> > >>>> diff --git a/git-gui/Makefile b/git-gui/Makefile > >>>> index cde8b2e..7564a18 100644 > >>>> --- a/git-gui/Makefile > >>>> +++ b/git-gui/Makefile > >>>> @@ -258,7 +258,7 @@ lib/tclIndex: $(ALL_LIBFILES) GIT-GUI-VARS > >>>> rm -f $@ ; \ > >>>> echo '# Autogenerated by git-gui Makefile' >$@ && \ > >>>> echo >>$@ && \ > >>>> - $(foreach p,$(PRELOAD_FILES) $(ALL_LIBFILES),echo '$(subst lib/,,$p)' >>$@ &&) \ > >>>> + $(foreach p,$(PRELOAD_FILES) $(sort $(ALL_LIBFILES)),echo '$(subst lib/,,$p)' >>$@ &&) \ > >>>> echo >>$@ ; \ > >>>> fi > >>>> > > > > Applied. Thank you. ```