threads / patch / 38194

patchDocumentation: config: typo fixed

Subject: [PATCH 1/1] Documentation: config: typo fixed

## tl;dr

4 messages between Dec 18, 2014 and Dec 18, 2014. Diffs are folded; open one to read it.

replies: 3people: 2as markdown or json

Alexander Kuleshov· Dec 18, 2014, 11:27 UTC · lore
From: 0xAX <kuleshovmail@gmail.com>
Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
---
 Documentation/config.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Show changes to Documentation/config.txt +1 −1
diff --git a/Documentation/config.txt b/Documentation/config.txt
index f615a5c..a995b68 100644
--- a/Documentation/config.txt
+++ b/Documentation/config.txt
@@ -203,7 +203,7 @@ advice.*::
 		show directions on how to proceed from the current state.
 --
 
-core.fileMode::
+core.filemode::
 	Tells Git if the executable bit of files in the working tree
 	is to be honored.
 +

-- 
2.2.0.64.g3889e7a.dirty
Alexander Kuleshov· Dec 18, 2014, 11:30 UTC · re: Alexander Kuleshov · lore
Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
---
 Documentation/config.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Show changes to Documentation/config.txt +1 −1
diff --git a/Documentation/config.txt b/Documentation/config.txt
index f615a5c..a995b68 100644
--- a/Documentation/config.txt
+++ b/Documentation/config.txt
@@ -203,7 +203,7 @@ advice.*::
 		show directions on how to proceed from the current state.
 --
 
-core.fileMode::
+core.filemode::
 	Tells Git if the executable bit of files in the working tree
 	is to be honored.
 +

-- 
2.2.0.64.g3889e7a.dirty
Matthieu Moy· Dec 18, 2014, 13:40 UTC · re: Alexander Kuleshov · lore

Re: [PATCH 1/1] Documentation: config: typo fixed

Alexander Kuleshov <kuleshovmail@gmail.com> writes:
> -core.fileMode::
> +core.filemode::
>  	Tells Git if the executable bit of files in the working tree
>  	is to be honored.

I do not think that this is a good change: config variable names are case insensitive, so filemode and fileMode are both correct. The convention used elsewhere in the documentation is CamelCasing, so the old version seems better to me.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/

← back to recent threads