# [PATCH] t5400: remove dead code 2 messages from 2014-12-16 to 2014-12-16. Participants: Stefan Beller, Junio C Hamano. Thread: https://gitlist.dev/t/38183 ## Stefan Beller, 2014-12-16 03:58 Subject: [PATCH] t5400: remove dead code Message-ID: <1418702287-13771-1-git-send-email-sbeller@google.com> URL: https://gitlist.dev/e/1418702287-13771-1-git-send-email-sbeller%40google.com ``` Signed-off-by: Stefan Beller --- Notes: When debugging the atomic push series I wondered if we want to have tests for the atomic push as well as for atomic send-pack. So I looked at the t5400 test if I could easily add tests for send-pack. I don't think I will add tests in here, but I found dead code. Also I am rambling about the other series this patch is totally unrelated. Removing dead code is always a joy! Thanks, Stefan t/t5400-send-pack.sh | 16 +--------------- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/t/t5400-send-pack.sh b/t/t5400-send-pack.sh index 0736bcb..04cea97 100755 --- a/t/t5400-send-pack.sh +++ b/t/t5400-send-pack.sh @@ -76,8 +76,7 @@ test_expect_success 'refuse pushing rewound head without --force' ' test "$victim_head" = "$pushed_head" ' -test_expect_success \ - 'push can be used to delete a ref' ' +test_expect_success 'push can be used to delete a ref' ' ( cd victim && git branch extra master ) && git send-pack ./victim :extra master && ( cd victim && @@ -196,19 +195,6 @@ rewound_push_setup() { ) } -rewound_push_succeeded() { - cmp ../parent/.git/refs/heads/master .git/refs/heads/master -} - -rewound_push_failed() { - if rewound_push_succeeded - then - false - else - true - fi -} - test_expect_success 'pushing explicit refspecs respects forcing' ' rewound_push_setup && parent_orig=$(cd parent && git rev-parse --verify master) && -- 2.2.0.31.gad78000.dirty ``` ## Junio C Hamano, 2014-12-16 18:58 Subject: Re: [PATCH] t5400: remove dead code Message-ID: URL: https://gitlist.dev/e/xmqqfvcfbew2.fsf%40gitster.dls.corp.google.com In-Reply-To: <1418702287-13771-1-git-send-email-sbeller@google.com> ``` Thanks. ```