# [PATCH] refs.c: let fprintf handle the formatting 2 messages from 2014-12-05 to 2014-12-05. Participants: Stefan Beller. Thread: https://gitlist.dev/t/38118 ## Stefan Beller, 2014-12-05 19:53 Subject: [PATCH] refs.c: let fprintf handle the formatting Message-ID: <1417809221-27209-1-git-send-email-sbeller@google.com> URL: https://gitlist.dev/e/1417809221-27209-1-git-send-email-sbeller%40google.com ``` Instead of calculating, whether to put a plus or minus sign, offload the responsibilty to the fprintf function. Signed-off-by: Stefan Beller --- refs.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/refs.c b/refs.c index 40c5591..1147216 100644 --- a/refs.c +++ b/refs.c @@ -3972,12 +3972,9 @@ static int expire_reflog_ent(unsigned char *osha1, unsigned char *nsha1, printf("prune %s", message); } else { if (cb->newlog) { - char sign = (tz < 0) ? '-' : '+'; - int zone = (tz < 0) ? (-tz) : tz; - fprintf(cb->newlog, "%s %s %s %lu %c%04d\t%s", + fprintf(cb->newlog, "%s %s %s %lu %+05d\t%s", sha1_to_hex(osha1), sha1_to_hex(nsha1), - email, timestamp, sign, zone, - message); + email, timestamp, tz, message); hashcpy(cb->last_kept_sha1, nsha1); } if (cb->flags & EXPIRE_REFLOGS_VERBOSE) -- 2.2.0 ``` ## Stefan Beller, 2014-12-05 19:54 Subject: Re: [PATCH] refs.c: let fprintf handle the formatting Message-ID: URL: https://gitlist.dev/e/CAGZ79kbYDK0kJuwk%2Bksx3iB2cHzKvP54rCaH1o2Pknh-Axcfqw%40mail.gmail.com In-Reply-To: <1417809221-27209-1-git-send-email-sbeller@google.com> ``` On Fri, Dec 5, 2014 at 11:53 AM, Stefan Beller wrote: > Instead of calculating, whether to put a plus or minus sign, offload > the responsibilty to the fprintf function. > > Signed-off-by: Stefan Beller > --- Ah! I forgot the --notes switch when sending out the email: Michael, please queue this on top of your reflog series. More to come. Thanks, Stefan > refs.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/refs.c b/refs.c > index 40c5591..1147216 100644 > --- a/refs.c > +++ b/refs.c > @@ -3972,12 +3972,9 @@ static int expire_reflog_ent(unsigned char *osha1, unsigned char *nsha1, > printf("prune %s", message); > } else { > if (cb->newlog) { > - char sign = (tz < 0) ? '-' : '+'; > - int zone = (tz < 0) ? (-tz) : tz; > - fprintf(cb->newlog, "%s %s %s %lu %c%04d\t%s", > + fprintf(cb->newlog, "%s %s %s %lu %+05d\t%s", > sha1_to_hex(osha1), sha1_to_hex(nsha1), > - email, timestamp, sign, zone, > - message); > + email, timestamp, tz, message); > hashcpy(cb->last_kept_sha1, nsha1); > } > if (cb->flags & EXPIRE_REFLOGS_VERBOSE) > -- > 2.2.0 > ```