# [PATCH] t0050-*.sh: mark the rename (case change) test as passing 2 messages from 2014-11-28 to 2014-11-28. Participants: Ramsay Jones, Eric Sunshine. Thread: https://gitlist.dev/t/38068 ## Ramsay Jones, 2014-11-28 16:57 Subject: [PATCH] t0050-*.sh: mark the rename (case change) test as passing Message-ID: <5478A96E.8030706@ramsay1.demon.co.uk> URL: https://gitlist.dev/e/5478A96E.8030706%40ramsay1.demon.co.uk ``` Since commit baa37bff ("mv: allow renaming to fix case on case insensitive filesystems", 08-05-2014), the 'git mv' command has been able to rename a file, to one which differs only in case, on a case insensitive filesystem. This results in the 'rename (case change)' test, which used to fail prior to this commit, to now (unexpectedly) pass. Mark this test as passing. Signed-off-by: Ramsay Jones --- Hi Junio, I noticed this last week while testing on cygwin. I have only tested this on (64-bit) cygwin/ntfs, but I would assume that other case insensitive filesystems would be OK, since there have been no complaints about t6039-merge-ignorecase.sh not working. Note that I didn't remove $test_case, despite having removed its last use in this test, in case there will be a future need. I'm not sure there will be a future need, of course, so if you would rather I got rid of it, just let me know. ATB, Ramsay Jones t/t0050-filesystem.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t0050-filesystem.sh b/t/t0050-filesystem.sh index 6b3cedc..988c392 100755 --- a/t/t0050-filesystem.sh +++ b/t/t0050-filesystem.sh @@ -64,7 +64,7 @@ test_expect_success "setup case tests" ' git checkout -f master ' -$test_case 'rename (case change)' ' +test_expect_success 'rename (case change)' ' git mv camelcase CamelCase && git commit -m "rename" ' -- 2.1.0 ``` ## Eric Sunshine, 2014-11-28 21:13 Subject: Re: [PATCH] t0050-*.sh: mark the rename (case change) test as passing Message-ID: URL: https://gitlist.dev/e/CAPig%2BcRbdy6obKNvBWqvvEQD%2BMwXcNw%2B0T0c-f1AuPA%2B_c%3D8%3DQ%40mail.gmail.com In-Reply-To: <5478A96E.8030706@ramsay1.demon.co.uk> ``` On Fri, Nov 28, 2014 at 11:57 AM, Ramsay Jones wrote: > Since commit baa37bff ("mv: allow renaming to fix case on case > insensitive filesystems", 08-05-2014), the 'git mv' command has > been able to rename a file, to one which differs only in case, > on a case insensitive filesystem. > > This results in the 'rename (case change)' test, which used to fail > prior to this commit, to now (unexpectedly) pass. Mark this test as > passing. > > Signed-off-by: Ramsay Jones > --- > > Hi Junio, > > I noticed this last week while testing on cygwin. I have only tested > this on (64-bit) cygwin/ntfs, but I would assume that other case > insensitive filesystems would be OK, since there have been no complaints > about t6039-merge-ignorecase.sh not working. I tested and verified that this patch is also needed on Mac OS X (as expected). > Note that I didn't remove $test_case, despite having removed its last > use in this test, in case there will be a future need. I'm not sure > there will be a future need, of course, so if you would rather I got > rid of it, just let me know. > > ATB, > Ramsay Jones > > t/t0050-filesystem.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/t/t0050-filesystem.sh b/t/t0050-filesystem.sh > index 6b3cedc..988c392 100755 > --- a/t/t0050-filesystem.sh > +++ b/t/t0050-filesystem.sh > @@ -64,7 +64,7 @@ test_expect_success "setup case tests" ' > git checkout -f master > ' > > -$test_case 'rename (case change)' ' > +test_expect_success 'rename (case change)' ' > git mv camelcase CamelCase && > git commit -m "rename" > ' > -- > 2.1.0 > -- > To unsubscribe from this list: send the line "unsubscribe git" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html ```