threads / patch / 37977

patchgitk: Enable mouse horizontal scrolling in diff pane

Subject: [PATCH] gitk: Enable mouse horizontal scrolling in diff pane

## tl;dr

3 messages between Nov 15, 2014 and Mar 22, 2015. Diffs are folded; open one to read it.

replies: 2people: 3as markdown or json

Gabriele Mazzotta· Nov 15, 2014, 14:05 UTC · lore

Currently it's required to hold Shift and scroll up and down to move horizontally. Listen to Button-6 and Button-7 events too to make horizontal scrolling handier with touchpads and some mice.

Signed-off-by: Gabriele Mazzotta <gabriele.mzt@gmail.com>
---
 gitk-git/gitk | 7 +++++++
 1 file changed, 7 insertions(+)

Show changes to gitk-git/gitk +7 −0

diff --git a/gitk-git/gitk b/gitk-git/gitk
index 78358a7..95a98e3 100755
--- a/gitk-git/gitk
+++ b/gitk-git/gitk
@@ -2516,6 +2516,13 @@ proc makewindow {} {
     } else {
 	bindall <ButtonRelease-4> "allcanvs yview scroll -5 units"
 	bindall <ButtonRelease-5> "allcanvs yview scroll 5 units"
+        bind $ctext <Button> {
+            if {"%b" eq 6} {
+                $ctext xview scroll -5 units
+            } elseif {"%b" eq 7} {
+                $ctext xview scroll 5 units
+            }
+        }
         if {[tk windowingsystem] eq "aqua"} {
             bindall <MouseWheel> {
                 set delta [expr {- (%D)}]

-- 
2.1.3

Stefan Haller· Nov 16, 2014, 08:00 UTC · re: Gabriele Mazzotta · lore

Re: [PATCH] gitk: Enable mouse horizontal scrolling in diff pane

Gabriele Mazzotta <gabriele.mzt@gmail.com> wrote:

> Currently it's required to hold Shift and scroll up and down to move
> horizontally. Listen to Button-6 and Button-7 events too to make
> horizontal scrolling handier with touchpads and some mice.

Hm, on my Macbook the diff pane already scrolls in all four directions with two-finger scrolling on the trackpad. (Without your patch, I mean.)

In my copy of gitk I did the opposite for the commit list though; I can't stand it that I accidentally scroll left or right with the trackpad, so I commented out some code to restrict it to only vertical scrolling. I never posted this patch because I bet many people like the current behaviour. Just so you know that such a change might be controversial.

-- 
Stefan Haller
Berlin, Germany
http://www.haller-berlin.de/

Paul Mackerras· Mar 22, 2015, 03:37 UTC · re: Gabriele Mazzotta · lore

Re: [PATCH] gitk: Enable mouse horizontal scrolling in diff pane

On Sat, Nov 15, 2014 at 03:05:06PM +0100, Gabriele Mazzotta wrote:

Show 5 quoted lines

> Currently it's required to hold Shift and scroll up and down to move
> horizontally. Listen to Button-6 and Button-7 events too to make
> horizontal scrolling handier with touchpads and some mice.
> 
> Signed-off-by: Gabriele Mazzotta <gabriele.mzt@gmail.com>

Thanks, applied.

Paul.