# [PATCH v4] Allow TTY tests to run under recent Mac OS 5 messages from 2014-11-14 to 2014-11-15. Participants: Mike Blume, Junio C Hamano, Jonathan Nieder, John Szakmeister. Thread: https://gitlist.dev/t/37968 ## Mike Blume, 2014-11-14 20:13 Subject: [PATCH v4] Allow TTY tests to run under recent Mac OS Message-ID: <1415995993-70879-1-git-send-email-blume.mike@gmail.com> URL: https://gitlist.dev/e/1415995993-70879-1-git-send-email-blume.mike%40gmail.com ``` TTY tests were previously skipped on all Mac OS systems because of a bug where reading from pty master occasionally hung. This bug has since been found not to be reproducible under Mac OS 10.9 and 10.10.1. Therefore, run TTY tests under Mac OS 10.9 (Mavericks) and higher. Signed-off-by: Mike Blume Improved-by: Junio C Hamano Signed-off-by: Junio C Hamano Improved-by: John Szakmeister Improved-by: Johannes Sixt Improved-by: Jeff King --- t/lib-terminal.sh | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/t/lib-terminal.sh b/t/lib-terminal.sh index 5184549..275fb09 100644 --- a/t/lib-terminal.sh +++ b/t/lib-terminal.sh @@ -29,7 +29,12 @@ test_lazy_prereq TTY ' # After 2000 iterations or so it hangs. # https://rt.cpan.org/Ticket/Display.html?id=65692 # - test "$(uname -s)" != Darwin && + # Under Mac OS X 10.9, this problem appears to be gone. + # + { + test "$(uname -s)" != Darwin || + test "$(uname -r | cut -d. -f1)" -ge 13 + } && perl "$TEST_DIRECTORY"/test-terminal.perl \ sh -c "test -t 1 && test -t 2" -- 2.2.0.rc1.197.g60bf093 ``` ## Junio C Hamano, 2014-11-14 20:20 Subject: Re: [PATCH v4] Allow TTY tests to run under recent Mac OS Message-ID: URL: https://gitlist.dev/e/xmqqbno9355t.fsf%40gitster.dls.corp.google.com In-Reply-To: <1415995993-70879-1-git-send-email-blume.mike@gmail.com> ``` Mike Blume writes: > TTY tests were previously skipped on all Mac OS systems because of a > bug where reading from pty master occasionally hung. This bug has since > been found not to be reproducible under Mac OS 10.9 and 10.10.1. > > Therefore, run TTY tests under Mac OS 10.9 (Mavericks) and higher. > > Signed-off-by: Mike Blume > Improved-by: Junio C Hamano > Signed-off-by: Junio C Hamano > Improved-by: John Szakmeister > Improved-by: Johannes Sixt > Improved-by: Jeff King > --- The patch in this round looks good. Will queue. Thanks all who helped. > t/lib-terminal.sh | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/t/lib-terminal.sh b/t/lib-terminal.sh > index 5184549..275fb09 100644 > --- a/t/lib-terminal.sh > +++ b/t/lib-terminal.sh > @@ -29,7 +29,12 @@ test_lazy_prereq TTY ' > # After 2000 iterations or so it hangs. > # https://rt.cpan.org/Ticket/Display.html?id=65692 > # > - test "$(uname -s)" != Darwin && > + # Under Mac OS X 10.9, this problem appears to be gone. > + # > + { > + test "$(uname -s)" != Darwin || > + test "$(uname -r | cut -d. -f1)" -ge 13 > + } && > > perl "$TEST_DIRECTORY"/test-terminal.perl \ > sh -c "test -t 1 && test -t 2" ``` ## Jonathan Nieder, 2014-11-14 23:21 Subject: Re: [PATCH v4] Allow TTY tests to run under recent Mac OS Message-ID: <20141114232106.GA6527@google.com> URL: https://gitlist.dev/e/20141114232106.GA6527%40google.com In-Reply-To: <1415995993-70879-1-git-send-email-blume.mike@gmail.com> ``` Hi, Mike Blume wrote: > TTY tests were previously skipped on all Mac OS systems because of a > bug where reading from pty master occasionally hung. This bug has since > been found not to be reproducible under Mac OS 10.9 and 10.10.1. > > Therefore, run TTY tests under Mac OS 10.9 (Mavericks) and higher. *puzzled* Testing on Yosemite with the following script[1] perl -MIO::Pty -MFile::Copy -e ' for (my $i = 0;; $i++) { my $master = new IO::Pty; my $slave = $master->slave; if (fork == 0) { close $master or die "close: $!"; open STDOUT, ">&", $slave or die "dup2: $!"; close $slave or die "close: $!"; exec("echo", "hi", $i) or die "exec: $!"; } close $slave or die "close: $!"; copy($master, \*STDOUT) or die "copy: $!"; close $master or die "close: $!"; wait; } ' still seems to hang eventually (after 61 iterations when my officemate tried it), reproducing the bug. Do you get a different result? The bug was originally found in an autobuilder that would run the test suite when new versions were pushed to check for regressions. Even if the hang only happened 0.1% of the time, that would get the autobuilder stuck after a while, which was how the problem got noticed. Thanks, Jonathan [1] https://rt.cpan.org/Public/Bug/Display.html?id=65692 ``` ## Junio C Hamano, 2014-11-14 23:29 Subject: Re: [PATCH v4] Allow TTY tests to run under recent Mac OS Message-ID: URL: https://gitlist.dev/e/xmqqh9y11huv.fsf%40gitster.dls.corp.google.com In-Reply-To: <20141114232106.GA6527@google.com> ``` Jonathan Nieder writes: > *puzzled* Testing on Yosemite with the following script[1] > ... > still seems to hang eventually (after 61 iterations when my officemate > tried it), reproducing the bug. Thanks. I've merged it to 'next' and pushed out the result already, but we may probably have to drop it. ``` ## John Szakmeister, 2014-11-15 00:14 Subject: Re: [PATCH v4] Allow TTY tests to run under recent Mac OS Message-ID: URL: https://gitlist.dev/e/CAEBDL5XHdRA1eqgEqdMV-HMA006XGcPQ%2BBVQgkhzhaGLErGwgw%40mail.gmail.com In-Reply-To: <20141114232106.GA6527@google.com> ``` On Fri, Nov 14, 2014 at 6:21 PM, Jonathan Nieder wrote: > Hi, > > Mike Blume wrote: > >> TTY tests were previously skipped on all Mac OS systems because of a >> bug where reading from pty master occasionally hung. This bug has since >> been found not to be reproducible under Mac OS 10.9 and 10.10.1. >> >> Therefore, run TTY tests under Mac OS 10.9 (Mavericks) and higher. > > *puzzled* Testing on Yosemite with the following script[1] > > perl -MIO::Pty -MFile::Copy -e ' > for (my $i = 0;; $i++) { > my $master = new IO::Pty; > my $slave = $master->slave; > if (fork == 0) { > close $master or die "close: $!"; > open STDOUT, ">&", $slave or die "dup2: $!"; > close $slave or die "close: $!"; > exec("echo", "hi", $i) or die "exec: $!"; > } > close $slave or die "close: $!"; > copy($master, \*STDOUT) or die "copy: $!"; > close $master or die "close: $!"; > wait; > } > ' > > still seems to hang eventually (after 61 iterations when my officemate > tried it), reproducing the bug. > > Do you get a different result? Interesting. It took quite a while, but it did finally fail on my Mavericks box on the 115,140th iteration. > The bug was originally found in an autobuilder that would run the test > suite when new versions were pushed to check for regressions. Even if > the hang only happened 0.1% of the time, that would get the > autobuilder stuck after a while, which was how the problem got > noticed. Eek... that's nasty. -John ```