# [PATCH v3] allow TTY tests to run under recent Mac OS 2 messages from 2014-11-14 to 2014-11-14. Participants: Mike Blume, Junio C Hamano. Thread: https://gitlist.dev/t/37966 ## Mike Blume, 2014-11-14 17:08 Subject: [PATCH v3] allow TTY tests to run under recent Mac OS Message-ID: <1415984885-59073-1-git-send-email-blume.mike@gmail.com> URL: https://gitlist.dev/e/1415984885-59073-1-git-send-email-blume.mike%40gmail.com ``` listed bug doesn't reproduce on Mac OS Yosemite or Mavericks. For now, just enable TTY on Mavericks and higher Signed-off-by: Mike Blume Improved-by: Junio C Hamano Signed-off-by: Junio C Hamano Improved-by: John Szakmeister --- t/lib-terminal.sh | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/t/lib-terminal.sh b/t/lib-terminal.sh index 5184549..7348f7e 100644 --- a/t/lib-terminal.sh +++ b/t/lib-terminal.sh @@ -29,7 +29,10 @@ test_lazy_prereq TTY ' # After 2000 iterations or so it hangs. # https://rt.cpan.org/Ticket/Display.html?id=65692 # - test "$(uname -s)" != Darwin && + # Under Mac OS X 10.10.1 and Perl 5.18.2, this problem + # appears to be gone. + # + test "$(uname -s)" != Darwin || test "$(uname -r | cut -d. -f1)" -ge 13 && perl "$TEST_DIRECTORY"/test-terminal.perl \ sh -c "test -t 1 && test -t 2" -- 2.2.0.rc1.197.g60bf093 ``` ## Junio C Hamano, 2014-11-14 19:34 Subject: Re: [PATCH v3] allow TTY tests to run under recent Mac OS Message-ID: URL: https://gitlist.dev/e/xmqqsihl37bn.fsf%40gitster.dls.corp.google.com In-Reply-To: <1415984885-59073-1-git-send-email-blume.mike@gmail.com> ``` Mike Blume writes: > listed bug doesn't reproduce on Mac OS Yosemite or Mavericks. For now, > just enable TTY on Mavericks and higher What is "listed bug" that begins a sentence in lowercase? End the description in full-stop, s/higher/&./; > > Signed-off-by: Mike Blume > Improved-by: Junio C Hamano > Signed-off-by: Junio C Hamano > Improved-by: John Szakmeister > --- > t/lib-terminal.sh | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/t/lib-terminal.sh b/t/lib-terminal.sh > index 5184549..7348f7e 100644 > --- a/t/lib-terminal.sh > +++ b/t/lib-terminal.sh > @@ -29,7 +29,10 @@ test_lazy_prereq TTY ' > # After 2000 iterations or so it hangs. > # https://rt.cpan.org/Ticket/Display.html?id=65692 > # > - test "$(uname -s)" != Darwin && > + # Under Mac OS X 10.10.1 and Perl 5.18.2, this problem > + # appears to be gone. > + # > + test "$(uname -s)" != Darwin || test "$(uname -r | cut -d. -f1)" -ge 13 && Is that "13" you have here consistent with "10.10.1" above in the comment? I am not a Mac person, but I vaguely recall that they are usually off by four. > > perl "$TEST_DIRECTORY"/test-terminal.perl \ > sh -c "test -t 1 && test -t 2" ```