threads / patch / 37962

patchgitk: po/ru.po russian translation typo fixed

Subject: [PATCH 1/1] gitk: po/ru.po russian translation typo fixed

## tl;dr

5 messages between Nov 14, 2014 and Mar 22, 2015. Diffs are folded; open one to read it.

replies: 4people: 3as markdown or json

0xAX· Nov 14, 2014, 11:05 UTC · lore
Signed-off-by: 0xAX <kuleshovmail@gmail.com>
---
 po/ru.po | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Show changes to po/ru.po +1 −1
diff --git a/po/ru.po b/po/ru.po
index 5987303..0a0754d 100644
--- a/po/ru.po
+++ b/po/ru.po
@@ -863,7 +863,7 @@ msgid ""
 "(discard ALL local changes)"
 msgstr ""
 "Жесткий: переписать индекс и рабочий каталог\n"
-"(все изменения в рабочем каталоги будут потеряны)"
+"(все изменения в рабочем каталоге будут потеряны)"
 
 #: gitk:8492
 msgid "Resetting"
-- 
2.1.3
Max Kirillov· Nov 14, 2014, 21:16 UTC · re: 0xAX · lore

Re: [PATCH 1/1] gitk: po/ru.po russian translation typo fixed

Hi.
On Fri, Nov 14, 2014 at 05:05:28PM +0600, 0xAX wrote:
> Signed-off-by: 0xAX <kuleshovmail@gmail.com>
> -"(все изменения в рабочем каталоги будут потеряны)"
> +"(все изменения в рабочем каталоге будут потеряны)"

I cannot say I see much sense to use software like Git with translations to national languages, but I confirm that the newer version is grammatically correct while the older is not. You may add "Reviewed-By: " with me or whatever tag is appropriate for my statement above.

btw, you might want to find the author of the string, with "git blame", and, if he is still active in the maillist, add him to To: or CC: for the patch.

-- 
Max
Paul Mackerras· Mar 22, 2015, 03:40 UTC · re: 0xAX · lore

Re: [PATCH 1/1] gitk: po/ru.po russian translation typo fixed

On Fri, Nov 14, 2014 at 05:05:28PM +0600, 0xAX wrote:
> Signed-off-by: 0xAX <kuleshovmail@gmail.com>
> ---
>  po/ru.po | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
Thanks, applied.
Paul.
Alex Kuleshov· Nov 17, 2014, 07:59 UTC · lore

Re: [PATCH 1/1] gitk: po/ru.po russian translation typo fixed

Hello Max and Paul,

thank you for your feedback, so what's must be my next workflow? Resend patch with "Reviewed-By:..." or somethine else?

-- Best regards. 0xAX

Max Kirillov· Nov 18, 2014, 05:23 UTC · re: Alex Kuleshov · lore

Re: [PATCH 1/1] gitk: po/ru.po russian translation typo fixed

On Mon, Nov 17, 2014 at 01:59:28PM +0600, Alex Kuleshov wrote:
Show 5 quoted lines
> 
> Hello Max and Paul,
> 
> thank you for your feedback, so what's must be my next workflow? Resend
> patch with "Reviewed-By:..." or somethine else?

To be honest I don't know. The only time I had such an answer maintainer put the flag himself at applying patch.

-- 
Max

← back to recent threads