# appropriate mailing list for gitk patches

2 messages from 2014-11-13 to 2014-11-13. Participants: lennart spitzner, Junio C Hamano.
Thread: https://gitlist.dev/t/37956

## lennart spitzner, 2014-11-13 21:10

Subject: appropriate mailing list for gitk patches
Message-ID: <54651E28.9090100@informatik.uni-kiel.de>
URL: https://gitlist.dev/e/54651E28.9090100%40informatik.uni-kiel.de

```
Hello folks,

I have a patch for gitk. Should i send it to this list, or is there some
other?  git/Documentation/SubmittingPatches mentions
git://ozlabs.org/~paulus/gitk (the master of which i based my commit
on), but never mentions any list(s) by name (only "the Git mailing
list", which i presume is this one).

Also, a minor question regarding patches: I wondered why patches do not
mention the commit id that the patch(es) are based on. My current guess
is that the diffs containing the sha1's is considered sufficient. Is
this the case? Are there more/other aspects?

Lennart

```

## Junio C Hamano, 2014-11-13 21:32

Subject: Re: appropriate mailing list for gitk patches
Message-ID: <xmqqegt6zt03.fsf@gitster.dls.corp.google.com>
URL: https://gitlist.dev/e/xmqqegt6zt03.fsf%40gitster.dls.corp.google.com
In-Reply-To: <54651E28.9090100@informatik.uni-kiel.de>

```
lennart spitzner <lsp@informatik.uni-kiel.de> writes:

> I have a patch for gitk. Should i send it to this list, or is there some
> other?  git/Documentation/SubmittingPatches mentions
> git://ozlabs.org/~paulus/gitk (the master of which i based my commit
> on), but never mentions any list(s) by name (only "the Git mailing
> list", which i presume is this one).

You are in the right place ;-)  Make sure you Cc: paulus as the area
maintainer on your patches, though.

> Also, a minor question regarding patches: I wondered why patches do not
> mention the commit id that the patch(es) are based on. My current guess
> is that the diffs containing the sha1's is considered sufficient. Is
> this the case? Are there more/other aspects?

A new development is done based on the tip of 'master' by convention
around here, so people know it is meant to apply there unless the
patch submitter says otherwise explicitly.

People send patches on a random commit of their own that is not
available to the public (e.g. you may be working on some big topic,
discover a simple bug that is not related to the topic, and create a
fix for that simple bug right there on top and send that out as a
patch).  Base commit object name would be useless in such a case
anyway.

```