# [PATCH] run-command: use void to declare that functions take no parameters 4 messages from 2014-11-10 to 2014-11-11. Participants: René Scharfe, Junio C Hamano, Jeff King. Thread: https://gitlist.dev/t/37927 ## René Scharfe, 2014-11-10 21:17 Subject: [PATCH] run-command: use void to declare that functions take no parameters Message-ID: <54612B4C.8010609@web.de> URL: https://gitlist.dev/e/54612B4C.8010609%40web.de ``` Explicitly declare that git_atexit_dispatch() and git_atexit_clear() take no parameters instead of leaving their parameter list empty and thus unspecified. Signed-off-by: Rene Scharfe --- run-command.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/run-command.c b/run-command.c index 79a0a76..a476999 100644 --- a/run-command.c +++ b/run-command.c @@ -636,7 +636,7 @@ static struct { static int git_atexit_installed; -static void git_atexit_dispatch() +static void git_atexit_dispatch(void) { size_t i; @@ -644,7 +644,7 @@ static void git_atexit_dispatch() git_atexit_hdlrs.handlers[i-1](); } -static void git_atexit_clear() +static void git_atexit_clear(void) { free(git_atexit_hdlrs.handlers); memset(&git_atexit_hdlrs, 0, sizeof(git_atexit_hdlrs)); -- 2.1.3 ``` ## Junio C Hamano, 2014-11-10 22:43 Subject: Re: [PATCH] run-command: use void to declare that functions take no parameters Message-ID: URL: https://gitlist.dev/e/xmqq7fz28yo1.fsf%40gitster.dls.corp.google.com In-Reply-To: <54612B4C.8010609@web.de> ``` René Scharfe writes: > Explicitly declare that git_atexit_dispatch() and git_atexit_clear() > take no parameters instead of leaving their parameter list empty and > thus unspecified. > > Signed-off-by: Rene Scharfe > --- Thanks. I was kind of surprised after running a git blame to find that this is a recent thing, and the same patch looked quite substandard with numerious style violations, and I somehow managed to let them slip in X-<. Perhaps I was having a bad day or something... > run-command.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/run-command.c b/run-command.c > index 79a0a76..a476999 100644 > --- a/run-command.c > +++ b/run-command.c > @@ -636,7 +636,7 @@ static struct { > > static int git_atexit_installed; > > -static void git_atexit_dispatch() > +static void git_atexit_dispatch(void) > { > size_t i; > > @@ -644,7 +644,7 @@ static void git_atexit_dispatch() > git_atexit_hdlrs.handlers[i-1](); > } > > -static void git_atexit_clear() > +static void git_atexit_clear(void) > { > free(git_atexit_hdlrs.handlers); > memset(&git_atexit_hdlrs, 0, sizeof(git_atexit_hdlrs)); ``` ## Jeff King, 2014-11-11 02:54 Subject: Re: [PATCH] run-command: use void to declare that functions take no parameters Message-ID: <20141111025415.GB21328@peff.net> URL: https://gitlist.dev/e/20141111025415.GB21328%40peff.net In-Reply-To: ``` On Mon, Nov 10, 2014 at 02:43:10PM -0800, Junio C Hamano wrote: > > Explicitly declare that git_atexit_dispatch() and git_atexit_clear() > > take no parameters instead of leaving their parameter list empty and > > thus unspecified. > [...] > > I was kind of surprised after running a git blame to find that this > is a recent thing, and the same patch looked quite substandard with > numerious style violations, and I somehow managed to let them slip > in X-<. Perhaps I was having a bad day or something... I had always just assumed that -Wstrict-prototypes was part of -Wall, but it is not (nor even part of -Wextra!). Maybe it is time to add it to your integration-build flags. :) Looks like we also need this on top of hv/submodule-config (still in pu, so squashing is probably best): diff --git a/submodule-config.h b/submodule-config.h index 58afc83..9061e4e 100644 --- a/submodule-config.h +++ b/submodule-config.h @@ -24,6 +24,6 @@ const struct submodule *submodule_from_name(const unsigned char *commit_sha1, const char *name); const struct submodule *submodule_from_path(const unsigned char *commit_sha1, const char *path); -void submodule_free(); +void submodule_free(void); #endif /* SUBMODULE_CONFIG_H */ -Peff ``` ## Junio C Hamano, 2014-11-11 17:32 Subject: Re: [PATCH] run-command: use void to declare that functions take no parameters Message-ID: URL: https://gitlist.dev/e/xmqqegt97idj.fsf%40gitster.dls.corp.google.com In-Reply-To: <20141111025415.GB21328@peff.net> ``` Jeff King writes: > I had always just assumed that -Wstrict-prototypes was part of -Wall, > but it is not (nor even part of -Wextra!). Maybe it is time to add it to > your integration-build flags. :) Yup, I had -Wold-style-definition but not -Wstrict-prototypes in the mix. Thanks for spotting. > > Looks like we also need this on top of hv/submodule-config (still in pu, > so squashing is probably best): > > diff --git a/submodule-config.h b/submodule-config.h > index 58afc83..9061e4e 100644 > --- a/submodule-config.h > +++ b/submodule-config.h > @@ -24,6 +24,6 @@ const struct submodule *submodule_from_name(const unsigned char *commit_sha1, > const char *name); > const struct submodule *submodule_from_path(const unsigned char *commit_sha1, > const char *path); > -void submodule_free(); > +void submodule_free(void); > > #endif /* SUBMODULE_CONFIG_H */ > > -Peff ```