# [PATCH] configure.ac: quote AC_PREREQ in configure.ac 2 messages from 2014-10-31 to 2014-10-31. Participants: Elia Pinto, Junio C Hamano. Thread: https://gitlist.dev/t/37857 ## Elia Pinto, 2014-10-31 14:17 Subject: [PATCH] configure.ac: quote AC_PREREQ in configure.ac Message-ID: <1414765046-15703-1-git-send-email-gitter.spiros@gmail.com> URL: https://gitlist.dev/e/1414765046-15703-1-git-send-email-gitter.spiros%40gmail.com ``` For a old bug autoupdate don't do it before autoconf v2.66 Signed-off-by: Elia Pinto --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 6af9647..9f01999 100644 --- a/configure.ac +++ b/configure.ac @@ -141,7 +141,7 @@ fi ## Configure body starts here. -AC_PREREQ(2.59) +AC_PREREQ([2.59]) AC_INIT([git], [@@GIT_VERSION@@], [git@vger.kernel.org]) AC_CONFIG_SRCDIR([git.c]) -- 1.7.10.4 ``` ## Junio C Hamano, 2014-10-31 19:55 Subject: Re: [PATCH] configure.ac: quote AC_PREREQ in configure.ac Message-ID: URL: https://gitlist.dev/e/xmqqioj0t3ne.fsf%40gitster.dls.corp.google.com In-Reply-To: <1414765046-15703-1-git-send-email-gitter.spiros@gmail.com> ``` Elia Pinto writes: > For a old bug autoupdate don't do it before autoconf v2.66 I am having a hard time parsing this. What is the practical issue that comes from the lack of quoting here? It won't be like somebody defines a macro to allow 2.59 to expand to something else, confusing the machinery, so...? > > Signed-off-by: Elia Pinto > --- > configure.ac | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure.ac b/configure.ac > index 6af9647..9f01999 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -141,7 +141,7 @@ fi > > ## Configure body starts here. > > -AC_PREREQ(2.59) > +AC_PREREQ([2.59]) > AC_INIT([git], [@@GIT_VERSION@@], [git@vger.kernel.org]) > > AC_CONFIG_SRCDIR([git.c]) ```