threads / patch / 37806

patchgit-svn: save a little memory as fetch progresses

Subject: [PATCH] git-svn: save a little memory as fetch progresses

## tl;dr

One message between Oct 25, 2014 and Oct 25, 2014. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Eric Wong· Oct 25, 2014, 08:00 UTC · lore

There is no reason to keep entries in the %revs hash after we're done processing a revision, so allow entries become freed as processing continues.

Signed-off-by: Eric Wong <normalperson@yhbt.net>
---
 perl/Git/SVN/Ra.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Show changes to perl/Git/SVN/Ra.pm +1 −1
diff --git a/perl/Git/SVN/Ra.pm b/perl/Git/SVN/Ra.pm
index e326849..5bc5b4e 100644
--- a/perl/Git/SVN/Ra.pm
+++ b/perl/Git/SVN/Ra.pm
@@ -431,7 +431,7 @@ sub gs_fetch_loop_common {
 
 		my %exists = map { $_->path => $_ } @$gsv;
 		foreach my $r (sort {$a <=> $b} keys %revs) {
-			my ($paths, $logged) = @{$revs{$r}};
+			my ($paths, $logged) = @{delete $revs{$r}};
 
 			foreach my $gs ($self->match_globs(\%exists, $paths,
 			                                   $globs, $r)) {
-- 
EW

← back to recent threads