# [PATCH] dir.c: remove the second declaration of "stk" in prep_exclude()

1 messages from 2014-10-21 to 2014-10-21. Participants: Nguyễn Thái Ngọc Duy.
Thread: https://gitlist.dev/t/37773

## Nguyễn Thái Ngọc Duy, 2014-10-21 11:38

Subject: [PATCH] dir.c: remove the second declaration of "stk" in prep_exclude()
Message-ID: <1413891486-24573-1-git-send-email-pclouds@gmail.com>
URL: https://gitlist.dev/e/1413891486-24573-1-git-send-email-pclouds%40gmail.com

```
This "stk" shadows the first declaration at the top. There's currently
no bad effect. But let's avoid it.

Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
 dir.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dir.c b/dir.c
index bd274a7..3f7a025 100644
--- a/dir.c
+++ b/dir.c
@@ -826,9 +826,9 @@ static void prep_exclude(struct dir_struct *dir, const char *base, int baselen)
 	current = stk ? stk->baselen : -1;
 	strbuf_setlen(&dir->basebuf, current < 0 ? 0 : current);
 	while (current < baselen) {
-		struct exclude_stack *stk = xcalloc(1, sizeof(*stk));
 		const char *cp;
 
+		stk = xcalloc(1, sizeof(*stk));
 		if (current < 0) {
 			cp = base;
 			current = 0;
-- 
2.1.0.rc0.78.gc0d8480

```