__git_ps1_colorize__gitstring() in git_prompt.sh: colors are hardcoded?

Hello,

It seems to me that the colors used to indicate the repo's state in the prompt are hardcoded although the top comment says otherwise.

[83]# If you would like a colored hint about the current dirty state, set # GIT_PS1_SHOWCOLORHINTS to a nonempty value. The colors are based on # the colored output of "git status -sb" and are available only when # using __git_ps1 for PROMPT_COMMAND or precmd.

[228]__git_ps1_colorize_gitstring ()
{
	if [[ -n ${ZSH_VERSION-} ]]; then
		local c_red='%F{red}'
		local c_green='%F{green}'
		local c_lblue='%F{blue}'
		local c_clear='%f'
	else
		# Using \[ and \] around colors is necessary to prevent
		# issues with command line editing/browsing/completion!
		local c_red='\[\e[31m\]'
		local c_green='\[\e[32m\]'
		local c_lblue='\[\e[1;34m\]'
		local c_clear='\[\e[0m\]'
	fi
	local bad_color=$c_red
	local ok_color=$c_green
	local flags_color="$c_lblue"

	local branch_color=""

As expected upon seeing this snippet, the color.status.<slot> entries in the git config file do modify the git status -sb output but don't modify the colors used in the prompt.

Regards,

Nathan

nathdwek schrieb am 17.10.2014 um 19:30:

That should have said "... on the default colors used for the colored output of..."

The script could query config for these colors, but that would amount to 4 additional forks and "git config" calls each time a prompt is generated. If you want the colors to be configurable, you should probably rather introduce environment variables - or edit your copy of the script ;)

Cheers, Michael