# PATCH] mingw: Fix a typo in the pipe() implementation.

1 messages from 2014-10-09 to 2014-10-09. Participants: Ralph Loader.
Thread: https://gitlist.dev/t/37696

## Ralph Loader, 2014-10-09 08:03

Subject: PATCH] mingw: Fix a typo in the pipe() implementation.
Message-ID: <20141009210359.57a0bdab1f8f8700dc206e76@ihug.co.nz>
URL: https://gitlist.dev/e/20141009210359.57a0bdab1f8f8700dc206e76%40ihug.co.nz

```
We checked the first file descriptor for errors twice, instead of
checking both file descriptors.

Signed-off-by: Ralph Loader <rcl@ihug.co.nz>
---
While this appears utterly trivial, I noticed this reading the code not
running it - I do not have the relevant OS to compile and test on.

 compat/mingw.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/compat/mingw.c b/compat/mingw.c
index c5c37e5..7c92783 100644
--- a/compat/mingw.c
+++ b/compat/mingw.c
@@ -681,7 +681,7 @@ int pipe(int filedes[2])
 		return -1;
 	}
 	filedes[1] = _open_osfhandle((int)h[1], O_NOINHERIT);
-	if (filedes[0] < 0) {
+	if (filedes[1] < 0) {
 		close(filedes[0]);
 		CloseHandle(h[1]);
 		return -1;
-- 
2.1.0

```