threads / patch / 3762

patchcg-log: Remove unpleasant DEL characters.

Subject: [PATCH] cg-log: Remove unpleasant DEL characters.

## tl;dr

One message between Mar 31, 2006 and Mar 31, 2006. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Mark Wooding· Mar 31, 2006, 00:08 UTC · lore
From: Mark Wooding <mdw@distorted.org.uk>

There's a Bash bug (I'm running 3.1.5(1)-release from Debian testing) as follows:

  $ foo=@; echo "<${foo:1}>" | cat -v
  <^?>

Without this fix, less gives me ugly standout `^?' markers for every blank line in a commit message.

Signed-off-by: Mark Wooding <mdw@distorted.org.uk>
---
 cg-log |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Show changes to cg-log +1 −1
diff --git a/cg-log b/cg-log
index 5d5407b..b3374e4 100755
--- a/cg-log
+++ b/cg-log
@@ -181,7 +181,7 @@ process_commit_line()
 {
 	if [ "$key" = "%" ] || [ "$key" = "%$colsignoff" ]; then
 		# The fast common case
-		[ "$state" = silent ] || msg="$msg    ${rest:1}
+		[ "$state" = silent ] || msg="$msg    ${rest#?}
 "
 		return
 	fi

← back to recent threads