threads / patch / 3749

patchUnclutter cg status with --directory as GIT does

Subject: [PATCH] Unclutter cg status with --directory as GIT does

## tl;dr

4 messages between Mar 29, 2006 and Mar 29, 2006. Diffs are folded; open one to read it.

replies: 3people: 2as markdown or json

Paolo 'Blaisorblade' Giarrusso· Mar 29, 2006, 14:25 UTC · lore
From: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
From: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>

Pass the new --directory option (from git 1.1) to git-ls-others for list_untracked_files, as does git-status - it's very useful.

Probably this must be deferred to when the git 1.1 dependency is added, however please queue it for then.

Thanks.
Signed-off-by: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
---
 cg-Xlib |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Show changes to cg-Xlib +1 −1
diff --git a/cg-Xlib b/cg-Xlib
index 2b93c11..3150470 100644
--- a/cg-Xlib
+++ b/cg-Xlib
@@ -274,7 +274,7 @@ list_untracked_files()
 	fi
 	local listdirs=
 	[ "$squashflag" = "squashdirs" ] && listdirs=--directory
-	git-ls-files -z --others $listdirs "${EXCLUDE[@]}"
+	git-ls-files -z --others --directory $listdirs "${EXCLUDE[@]}"
 }
 
 pick_id()
Petr Baudis· Mar 29, 2006, 14:54 UTC · re: Paolo 'Blaisorblade' Giarrusso · lore

Re: [PATCH] Unclutter cg status with --directory as GIT does

Dear diary, on Wed, Mar 29, 2006 at 04:25:59PM CEST, I got a letter where Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it> said that...

Show 5 quoted lines
> Pass the new --directory option (from git 1.1) to git-ls-others for
> list_untracked_files, as does git-status - it's very useful.
> 
> Probably this must be deferred to when the git 1.1 dependency is added, however
> please queue it for then.
Uh, I'm confused. Cogito now depends on git-1.1, and
Show 10 quoted lines
> diff --git a/cg-Xlib b/cg-Xlib
> index 2b93c11..3150470 100644
> --- a/cg-Xlib
> +++ b/cg-Xlib
> @@ -274,7 +274,7 @@ list_untracked_files()
>  	fi
>  	local listdirs=
>  	[ "$squashflag" = "squashdirs" ] && listdirs=--directory
> -	git-ls-files -z --others $listdirs "${EXCLUDE[@]}"
> +	git-ls-files -z --others --directory $listdirs "${EXCLUDE[@]}"

as you can see, if list_untracked_files was pssed the 'squashdirs' option, it will already pass it. What cg command would you like to squash dirs except cg-status?

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
Right now I am having amnesia and deja-vu at the same time.  I think
I have forgotten this before.
Blaisorblade· Mar 29, 2006, 15:04 UTC · re: Petr Baudis · lore

Re: [PATCH] Unclutter cg status with --directory as GIT does

On Wednesday 29 March 2006 16:54, Petr Baudis wrote:
> Dear diary, on Wed, Mar 29, 2006 at 04:25:59PM CEST, I got a letter
> where Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it> said that...
> > Pass the new --directory option (from git 1.1) to git-ls-others for
> > list_untracked_files, as does git-status - it's very useful.
> > Probably this must be deferred to when the git 1.1 dependency is added,
> > however please queue it for then.
> Uh, I'm confused. Cogito now depends on git-1.1, and
> as you can see, if list_untracked_files was pssed the 'squashdirs'
> option, it will already pass it. What cg command would you like to
> squash dirs except cg-status?
Sorry, that's just an old patch then, I didn't note you did it yourself.

I wrote it before you had the 1.1 dependency and didn't notice you made something similar.

Bye and sorry for the noise
-- 
Inform me of my mistakes, so I can keep imitating Homer Simpson's "Doh!".
Paolo Giarrusso, aka Blaisorblade (Skype ID "PaoloGiarrusso", ICQ 215621894)
http://www.user-mode-linux.org/~blaisorblade

	

	
		
___________________________________ 
Yahoo! Mail: gratis 1GB per i messaggi e allegati da 10MB 
http://mail.yahoo.it
Petr Baudis· Mar 29, 2006, 15:08 UTC · re: Blaisorblade · lore

Re: [PATCH] Unclutter cg status with --directory as GIT does

Dear diary, on Wed, Mar 29, 2006 at 05:04:14PM CEST, I got a letter where Blaisorblade <blaisorblade@yahoo.it> said that...

> Sorry, that's just an old patch then, I didn't note you did it yourself.
> 
> I wrote it before you had the 1.1 dependency and didn't notice you made 
> something similar.
Well, I've just applied your patch :-) :

commit 4e1cd8ac4815bdc3e6671a2a5a266a9ca675630d author Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it> Thu, 19 Jan 2006 22:16:46 +0100 committer Petr Baudis <xpasky@machine.or.cz> Sat, 21 Jan 2006 02:21:13 +0100

Kind regards,
-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
Right now I am having amnesia and deja-vu at the same time.  I think
I have forgotten this before.

← back to recent threads