threads / patch / 37455

patchconfig: simplify git_config_include()

Subject: [PATCH] config: simplify git_config_include()

## tl;dr

One message between Aug 30, 2014 and Aug 30, 2014. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

René Scharfe· Aug 30, 2014, 16:07 UTC · lore

Instead of using skip_prefix() to check the first part of the string and then strcmp() to check the rest, simply use strcmp() to check the whole string.

Signed-off-by: Rene Scharfe <l.s.r@web.de>
---
 config.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
Show changes to config.c +1 −5
diff --git a/config.c b/config.c
index 058505c..c558a21 100644
--- a/config.c
+++ b/config.c
@@ -127,7 +127,6 @@ static int handle_path_include(const char *path, struct config_include_data *inc
 int git_config_include(const char *var, const char *value, void *data)
 {
 	struct config_include_data *inc = data;
-	const char *type;
 	int ret;
 
 	/*
@@ -138,10 +137,7 @@ int git_config_include(const char *var, const char *value, void *data)
 	if (ret < 0)
 		return ret;
 
-	if (!skip_prefix(var, "include.", &type))
-		return ret;
-
-	if (!strcmp(type, "path"))
+	if (!strcmp(var, "include.path"))
 		ret = handle_path_include(value, inc);
 	return ret;
 }
-- 
2.1.0

← back to recent threads