# [PATCH] Document LF appearing in shallow command during send-pack/receive-pack 2 messages from 2014-08-27 to 2014-08-27. Participants: Shawn Pearce, Jonathan Nieder. Thread: https://gitlist.dev/t/37429 ## Shawn Pearce, 2014-08-27 20:46 Subject: [PATCH] Document LF appearing in shallow command during send-pack/receive-pack Message-ID: <1409172416-10750-1-git-send-email-spearce@spearce.org> URL: https://gitlist.dev/e/1409172416-10750-1-git-send-email-spearce%40spearce.org ``` The implementation sends an LF, but the protocol documentation was missing this detail. Signed-off-by: Shawn Pearce --- Documentation/technical/pack-protocol.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/technical/pack-protocol.txt b/Documentation/technical/pack-protocol.txt index 18dea8d..569c48a 100644 --- a/Documentation/technical/pack-protocol.txt +++ b/Documentation/technical/pack-protocol.txt @@ -467,7 +467,7 @@ references. ---- update-request = *shallow command-list [pack-file] - shallow = PKT-LINE("shallow" SP obj-id) + shallow = PKT-LINE("shallow" SP obj-id LF) command-list = PKT-LINE(command NUL capability-list LF) *PKT-LINE(command LF) -- 2.1.0.rc2.206.gedb03e5 ``` ## Jonathan Nieder, 2014-08-27 22:10 Subject: Re: [PATCH] Document LF appearing in shallow command during send-pack/receive-pack Message-ID: <20140827221017.GY20185@google.com> URL: https://gitlist.dev/e/20140827221017.GY20185%40google.com In-Reply-To: <1409172416-10750-1-git-send-email-spearce@spearce.org> ``` Shawn Pearce wrote: > The implementation sends an LF, but the protocol documentation was > missing this detail. > > Signed-off-by: Shawn Pearce > --- > Documentation/technical/pack-protocol.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/technical/pack-protocol.txt b/Documentation/technical/pack-protocol.txt > index 18dea8d..569c48a 100644 > --- a/Documentation/technical/pack-protocol.txt > +++ b/Documentation/technical/pack-protocol.txt > @@ -467,7 +467,7 @@ references. > ---- > update-request = *shallow command-list [pack-file] > > - shallow = PKT-LINE("shallow" SP obj-id) > + shallow = PKT-LINE("shallow" SP obj-id LF) In git, the client sends LF and the server is happy with or without LF. JGit and libgit2 don't send 'shallow' lines. Reviewed-by: Jonathan Nieder > > command-list = PKT-LINE(command NUL capability-list LF) > *PKT-LINE(command LF) > -- ```