threads / patch / 37403

v2, 3 partst0026: Add missing &&

Subject: [PATCH v2 3/3] t0026: Add missing &&

## tl;dr

2 messages between Aug 22, 2014 and Aug 25, 2014. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Torsten Bögershausen· Aug 22, 2014, 19:19 UTC · lore
Fix the broken && chain
Reported-By: Eric Sunshine <sunshine@sunshineco.com>
Signed-off-by: Torsten Bögershausen <tboegi@web.de>
---
 t/t0026-eol-config.sh | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Show changes to t/t0026-eol-config.sh +3 −3
diff --git a/t/t0026-eol-config.sh b/t/t0026-eol-config.sh
index 43a580a..4806969 100755
--- a/t/t0026-eol-config.sh
+++ b/t/t0026-eol-config.sh
@@ -84,9 +84,9 @@ test_expect_success NATIVE_CRLF 'eol native is crlf' '
 
 	rm -rf native_eol && mkdir native_eol &&
 	( cd native_eol &&
-	printf "*.txt text\n" > .gitattributes
-	printf "one\r\ntwo\r\nthree\r\n" > filedos.txt
-	printf "one\ntwo\nthree\n" > fileunix.txt
+	printf "*.txt text\n" > .gitattributes &&
+	printf "one\r\ntwo\r\nthree\r\n" > filedos.txt &&
+	printf "one\ntwo\nthree\n" > fileunix.txt &&
 	git init &&
 	git config core.autocrlf false &&
 	git config core.eol native &&
-- 
2.1.0.rc2.210.g636bceb
Junio C Hamano· Aug 25, 2014, 17:38 UTC · re: Torsten Bögershausen · lore

Re: [PATCH v2 3/3] t0026: Add missing &&

Torsten Bögershausen <tboegi@web.de> writes:
Show 5 quoted lines
> Fix the broken && chain
>
> Reported-By: Eric Sunshine <sunshine@sunshineco.com>
> Signed-off-by: Torsten Bögershausen <tboegi@web.de>
> ---

Please fold this kind of "oops fix breakages discovered in the version that hasn't been reached 'next'" to the patch that introduces the breakage, with "Helped-by: whom".

Thanks.
Show 20 quoted lines
>  t/t0026-eol-config.sh | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/t/t0026-eol-config.sh b/t/t0026-eol-config.sh
> index 43a580a..4806969 100755
> --- a/t/t0026-eol-config.sh
> +++ b/t/t0026-eol-config.sh
> @@ -84,9 +84,9 @@ test_expect_success NATIVE_CRLF 'eol native is crlf' '
>  
>  	rm -rf native_eol && mkdir native_eol &&
>  	( cd native_eol &&
> -	printf "*.txt text\n" > .gitattributes
> -	printf "one\r\ntwo\r\nthree\r\n" > filedos.txt
> -	printf "one\ntwo\nthree\n" > fileunix.txt
> +	printf "*.txt text\n" > .gitattributes &&
> +	printf "one\r\ntwo\r\nthree\r\n" > filedos.txt &&
> +	printf "one\ntwo\nthree\n" > fileunix.txt &&
>  	git init &&
>  	git config core.autocrlf false &&
>  	git config core.eol native &&

← back to recent threads