# [PATCH] commit: use commit_list_append() instead of duplicating its code

1 messages from 2014-07-10 to 2014-07-10. Participants: René Scharfe.
Thread: https://gitlist.dev/t/37094

## René Scharfe, 2014-07-10 09:47

Subject: [PATCH] commit: use commit_list_append() instead of duplicating its code
Message-ID: <53BE6143.1000507@web.de>
URL: https://gitlist.dev/e/53BE6143.1000507%40web.de

```
Signed-off-by: Rene Scharfe <l.s.r@web.de>
---
 commit.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/commit.c b/commit.c
index fb7897c..61d2e13 100644
--- a/commit.c
+++ b/commit.c
@@ -447,12 +447,7 @@ struct commit_list *copy_commit_list(struct commit_list *list)
 	struct commit_list *head = NULL;
 	struct commit_list **pp = &head;
 	while (list) {
-		struct commit_list *new;
-		new = xmalloc(sizeof(struct commit_list));
-		new->item = list->item;
-		new->next = NULL;
-		*pp = new;
-		pp = &new->next;
+		pp = commit_list_append(list->item, pp);
 		list = list->next;
 	}
 	return head;
-- 
2.0.0

```