# [PATCH] diff-tree: call free_commit_list() instead of duplicating its code

1 messages from 2014-07-08 to 2014-07-08. Participants: René Scharfe.
Thread: https://gitlist.dev/t/37078

## René Scharfe, 2014-07-08 16:21

Subject: [PATCH] diff-tree: call free_commit_list() instead of duplicating its code
Message-ID: <53BC1A71.2010904@web.de>
URL: https://gitlist.dev/e/53BC1A71.2010904%40web.de

```
Signed-off-by: Rene Scharfe <l.s.r@web.de>
---
 builtin/diff-tree.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/builtin/diff-tree.c b/builtin/diff-tree.c
index be6417d..ce0e019 100644
--- a/builtin/diff-tree.c
+++ b/builtin/diff-tree.c
@@ -22,14 +22,10 @@ static int stdin_diff_commit(struct commit *commit, char *line, int len)
 	if (isspace(line[40]) && !get_sha1_hex(line+41, sha1)) {
 		/* Graft the fake parents locally to the commit */
 		int pos = 41;
-		struct commit_list **pptr, *parents;
+		struct commit_list **pptr;
 
 		/* Free the real parent list */
-		for (parents = commit->parents; parents; ) {
-			struct commit_list *tmp = parents->next;
-			free(parents);
-			parents = tmp;
-		}
+		free_commit_list(commit->parents);
 		commit->parents = NULL;
 		pptr = &(commit->parents);
 		while (line[pos] && !get_sha1_hex(line + pos, sha1)) {
-- 
2.0.0

```