# trace.c: struct timeval tv not portable

1 messages from 2014-06-29 to 2014-06-29. Participants: Torsten Bögershausen.
Thread: https://gitlist.dev/t/37023

## Torsten Bögershausen, 2014-06-29 06:53

Subject: trace.c: struct timeval tv not portable
Message-ID: <53AFB7F8.7070701@web.de>
URL: https://gitlist.dev/e/53AFB7F8.7070701%40web.de

```

The following printout gives a warning:
(trace.c, arounf line 105)
	strbuf_addf(buf, "%02d:%02d:%02d.%06ld ", tm.tm_hour, tm.tm_min,
		    tm.tm_sec, tv.tv_usec);
trace.c:105: warning: format ‘%06ld’ expects type ‘long int’, but argument 6 has type ‘__darwin_suseconds_t’


A format string of  "%06ld" for is not always good for tv.tv_usec

http://pubs.opengroup.org/onlinepubs/009695399/basedefs/sys/time.h.html

A better solution would be:

	strbuf_addf(buf, "%02d:%02d:%02d.%06ld ", tm.tm_hour, tm.tm_min,
		    tm.tm_sec, (long int)tv.tv_usec);

```