# [PATCH v3] t9001: avoid not portable '\n' with sed 5 messages from 2014-06-10 to 2014-06-10. Participants: Torsten Bögershausen, Eric Sunshine, Junio C Hamano. Thread: https://gitlist.dev/t/36878 ## Torsten Bögershausen, 2014-06-10 04:07 Subject: [PATCH v3] t9001: avoid not portable '\n' with sed Message-ID: <5396849F.7060206@web.de> URL: https://gitlist.dev/e/5396849F.7060206%40web.de ``` t9001 used a '\n' in a sed expression to split one line into two lines, but the usage of '\n' in the "replacement string" is not portable. The '\n' can be used to match a newline in the "pattern space", but otherwise the meaning of '\n' is unspecified in POSIX. - Gnu versions of sed will treat '\n' as a newline character. - Other versions of sed (like /usr/bin/sed under Mac OS X) simply ignore the '\' before the 'n', treating '\n' as 'n'. For reference see: pubs.opengroup.org/onlinepubs/9699919799/utilities/sed.html http://www.gnu.org/software/sed/manual/sed.html As the test already requires perl as a prerequisite, use perl instead of sed. Signed-off-by: Torsten Bögershausen --- Sending a V3 patch seems "spammish", but after re-reading all the comments I think that the commit msg should point out the difference between POSIX sed and gnu sed somewhat better. t/t9001-send-email.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh index 64d9434..19a3ced 100755 --- a/t/t9001-send-email.sh +++ b/t/t9001-send-email.sh @@ -1342,7 +1342,7 @@ test_cover_addresses () { git format-patch --cover-letter -2 -o outdir && cover=`echo outdir/0000-*.patch` && mv $cover cover-to-edit.patch && - sed "s/^From:/$header: extra@address.com\nFrom:/" cover-to-edit.patch >"$cover" && + perl -pe "s/^From:/$header: extra\@address.com\nFrom:/" cover-to-edit.patch >"$cover" && git send-email \ --force \ --from="Example " \ -- 2.0.0.553.ged01b91 ``` ## Eric Sunshine, 2014-06-10 05:03 Subject: Re: [PATCH v3] t9001: avoid not portable '\n' with sed Message-ID: URL: https://gitlist.dev/e/CAPig%2BcTeqjj6pstzvRh2z6CW8ksW5tpz41%2BRzpO%3DAj2gYr7DAg%40mail.gmail.com In-Reply-To: <5396849F.7060206@web.de> ``` On Tue, Jun 10, 2014 at 12:07 AM, Torsten Bögershausen wrote: > t9001 used a '\n' in a sed expression to split one line into two lines, > but the usage of '\n' in the "replacement string" is not portable. > > The '\n' can be used to match a newline in the "pattern space", > but otherwise the meaning of '\n' is unspecified in POSIX. > > - Gnu versions of sed will treat '\n' as a newline character. > - Other versions of sed (like /usr/bin/sed under Mac OS X) > simply ignore the '\' before the 'n', treating '\n' as 'n'. > > For reference see: > pubs.opengroup.org/onlinepubs/9699919799/utilities/sed.html > http://www.gnu.org/software/sed/manual/sed.html > > As the test already requires perl as a prerequisite, use perl instead of sed. René Scharfe pointed out this useful resource [1] for writing portable 'sed' when he fixed [2] a problem on NetBSD in a test I had written. [1]: http://sed.sourceforge.net/sedfaq4.html [2]: http://thread.gmane.org/gmane.comp.version-control.git/231654 > Signed-off-by: Torsten Bögershausen > --- > Sending a V3 patch seems "spammish", but after re-reading all > the comments I think that the commit msg should point out the difference > between POSIX sed and gnu sed somewhat better. > > t/t9001-send-email.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh > index 64d9434..19a3ced 100755 > --- a/t/t9001-send-email.sh > +++ b/t/t9001-send-email.sh > @@ -1342,7 +1342,7 @@ test_cover_addresses () { > git format-patch --cover-letter -2 -o outdir && > cover=`echo outdir/0000-*.patch` && > mv $cover cover-to-edit.patch && > - sed "s/^From:/$header: extra@address.com\nFrom:/" cover-to-edit.patch >"$cover" && > + perl -pe "s/^From:/$header: extra\@address.com\nFrom:/" cover-to-edit.patch >"$cover" && > git send-email \ > --force \ > --from="Example " \ > -- > 2.0.0.553.ged01b91 ``` ## Junio C Hamano, 2014-06-10 05:55 Subject: Re: [PATCH v3] t9001: avoid not portable '\n' with sed Message-ID: URL: https://gitlist.dev/e/xmqqk38pb95s.fsf%40gitster.dls.corp.google.com In-Reply-To: <5396849F.7060206@web.de> ``` Torsten Bögershausen writes: > t9001 used a '\n' in a sed expression to split one line into two lines, > but the usage of '\n' in the "replacement string" is not portable. This looks peculiarly familiar; don't I already have it queued? ``` ## Torsten Bögershausen, 2014-06-10 06:30 Subject: Re: [PATCH v3] t9001: avoid not portable '\n' with sed Message-ID: <5396A618.5040306@web.de> URL: https://gitlist.dev/e/5396A618.5040306%40web.de In-Reply-To: ``` On 06/10/2014 07:55 AM, Junio C Hamano wrote: > Torsten Bögershausen writes: > >> t9001 used a '\n' in a sed expression to split one line into two lines, >> but the usage of '\n' in the "replacement string" is not portable. > This looks peculiarly familiar; don't I already have it queued? Yes, V2 is queued and in pu,and only the commit msg is changed between V2 and V3. I think that V3 explains the difference between POSIX sed and gnu sed much better, and does reflect all the comments from the list, which otherwise may be lost. And I suspect that not only the sed under Mac OS X does not handle this very '\n' different from gnu sed, or in other words, more platforms may not have a gnu sed and may need the fix. ``` ## Junio C Hamano, 2014-06-10 15:38 Subject: Re: [PATCH v3] t9001: avoid not portable '\n' with sed Message-ID: URL: https://gitlist.dev/e/xmqqmwdkai6u.fsf%40gitster.dls.corp.google.com In-Reply-To: <5396A618.5040306@web.de> ``` Torsten Bögershausen writes: > I think that V3 explains the difference between POSIX sed and > gnu sed much better, and does reflect all the comments from > the list, which otherwise may be lost. Too late for that as the patch is already in 'next' X-<. ```