threads / patch / 36837

v2t9001: avoid not portable '\n' with sed

Subject: [PATCH v2] t9001: avoid not portable '\n' with sed

## tl;dr

One message between Jun 4, 2014 and Jun 4, 2014. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Torsten Bögershausen· Jun 4, 2014, 19:42 UTC · lore

t9001 used a '\n' in a sed expression to split one line into two lines. Some versions of sed (/usr/bin/sed under Mac OS X) simply ignore the '\' before the 'n', treating '\n' as 'n'.

As the test already requires perl as a prerequisite, use perl instead of sed.
Signed-off-by: Torsten Bögershausen <tboegi@web.de>
---
 t/t9001-send-email.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Show changes to t/t9001-send-email.sh +1 −1
diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh
index 64d9434..19a3ced 100755
--- a/t/t9001-send-email.sh
+++ b/t/t9001-send-email.sh
@@ -1342,7 +1342,7 @@ test_cover_addresses () {
 	git format-patch --cover-letter -2 -o outdir &&
 	cover=`echo outdir/0000-*.patch` &&
 	mv $cover cover-to-edit.patch &&
-	sed "s/^From:/$header: extra@address.com\nFrom:/" cover-to-edit.patch >"$cover" &&
+	perl -pe "s/^From:/$header: extra\@address.com\nFrom:/" cover-to-edit.patch >"$cover" &&
 	git send-email \
 	  --force \
 	  --from="Example <nobody@example.com>" \
-- 
2.0.0.553.ged01b91

← back to recent threads