# [PATCH] diff-cache.c compilation warning fix. 2 messages from 2005-04-28 to 2005-04-28. Participants: Junio C Hamano. Thread: https://gitlist.dev/t/368 ## Junio C Hamano, 2005-04-28 04:15 Subject: [PATCH] diff-cache.c compilation warning fix. Message-ID: <7vekcvbkq8.fsf@assigned-by-dhcp.cox.net> URL: https://gitlist.dev/e/7vekcvbkq8.fsf%40assigned-by-dhcp.cox.net ``` Nobody uses return value from show_new_file() function but it is defined as returning int and falls off at the end without returning. Make it void. Signed-off-by: Junio C Hamano --- diff-cache.c | 2 +- 1 files changed, 1 insertion(+), 1 deletion(-) # - [PATCH] diff-tree -p implies diff-tree -p -r # + working tree --- k/diff-cache.c +++ l/diff-cache.c @@ -38,7 +38,7 @@ static int get_stat_data(struct cache_en return 0; } -static int show_new_file(struct cache_entry *new) +static void show_new_file(struct cache_entry *new) { unsigned char *sha1; unsigned int mode; ``` ## Junio C Hamano, 2005-04-28 04:59 Subject: [PATCH (take 2)] diff-cache.c compilation warning fix. Message-ID: <7vzmvja438.fsf@assigned-by-dhcp.cox.net> URL: https://gitlist.dev/e/7vzmvja438.fsf%40assigned-by-dhcp.cox.net In-Reply-To: <7vekcvbkq8.fsf@assigned-by-dhcp.cox.net> ``` Nobody uses return value from show_new_file() function but it is defined as returning int and falls off at the end without returning. Make it void. Signed-off-by: Junio C Hamano --- This is take 2. Earlier one was a botched patch that left "return -1" in the function. diff-cache.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) # - [PATCH] diff-tree -p implies diff-tree -p -r # + 04/27 21:50 diff.c clean up temporary file. --- k/diff-cache.c +++ l/diff-cache.c @@ -38,14 +38,14 @@ static int get_stat_data(struct cache_en return 0; } -static int show_new_file(struct cache_entry *new) +static void show_new_file(struct cache_entry *new) { unsigned char *sha1; unsigned int mode; /* New file in the index: it might actually be different in the working copy */ if (get_stat_data(new, &sha1, &mode) < 0) - return -1; + return; show_file("+", new, sha1, mode); } ```