# git-multimail: migration: Config is not iterable 4 messages from 2014-05-29 to 2014-05-31. Participants: Azat Khuzhin, Elijah Newren, Michael Haggerty. Thread: https://gitlist.dev/t/36784 ## Azat Khuzhin, 2014-05-29 14:22 Subject: git-multimail: migration: Config is not iterable Message-ID: <20140529142208.GB27005@azat> URL: https://gitlist.dev/e/20140529142208.GB27005%40azat ``` Hi there, Using the latest version of git-multimail there is an issue with migration: $ ~azat/git-multimail/git-multimail/migrate-mailhook-config --overwrite Traceback (most recent call last): File "/home/azat/git-multimail/git-multimail/migrate-mailhook-config", line 271, in main(sys.argv[1:]) File "/home/azat/git-multimail/git-multimail/migrate-mailhook-config", line 268, in main migrate_config(strict=options.strict, retain=options.retain, overwrite=options.overwrite) File "/home/azat/git-multimail/git-multimail/migrate-mailhook-config", line 159, in migrate_config if not _check_old_config_exists(old): File "/home/azat/git-multimail/git-multimail/migrate-mailhook-config", line 66, in _check_old_config_exists if name in old: TypeError: argument of type 'Config' is not iterable Tested on 2.6 and 2.7 python versions. If you revert 09d0d5b92203f019763e43cef1e57f76f117d2b4 ("Get Python files to pass pep8's tests.") there issue goes away. I understand that this is not the right solution and I'm not the guru of python, so just let you know. Thanks ``` ## Elijah Newren, 2014-05-29 16:06 Subject: Re: git-multimail: migration: Config is not iterable Message-ID: URL: https://gitlist.dev/e/CABPp-BHfUbh31ZBZk6XTMvmZjNioe1-rNpTn6tsHPNge2c-yTw%40mail.gmail.com In-Reply-To: <20140529142208.GB27005@azat> ``` On Thu, May 29, 2014 at 7:22 AM, Azat Khuzhin wrote: > Hi there, > > Using the latest version of git-multimail there is an issue with > migration: > > $ ~azat/git-multimail/git-multimail/migrate-mailhook-config --overwrite > Traceback (most recent call last): ... > File "/home/azat/git-multimail/git-multimail/migrate-mailhook-config", line 66, in _check_old_config_exists > if name in old: > TypeError: argument of type 'Config' is not iterable Thanks for the report. I'm not the strongest on python data model and its special methods but I believe I've got a fix: https://github.com/mhagger/git-multimail/pull/58 ``` ## Michael Haggerty, 2014-05-31 14:59 Subject: Re: git-multimail: migration: Config is not iterable Message-ID: <5389EE61.9060108@alum.mit.edu> URL: https://gitlist.dev/e/5389EE61.9060108%40alum.mit.edu In-Reply-To: <20140529142208.GB27005@azat> ``` On 05/29/2014 04:22 PM, Azat Khuzhin wrote: > Using the latest version of git-multimail there is an issue with > migration: > > $ ~azat/git-multimail/git-multimail/migrate-mailhook-config --overwrite > Traceback (most recent call last): > File "/home/azat/git-multimail/git-multimail/migrate-mailhook-config", line 271, in > main(sys.argv[1:]) > File "/home/azat/git-multimail/git-multimail/migrate-mailhook-config", line 268, in main > migrate_config(strict=options.strict, retain=options.retain, overwrite=options.overwrite) > File "/home/azat/git-multimail/git-multimail/migrate-mailhook-config", line 159, in migrate_config > if not _check_old_config_exists(old): > File "/home/azat/git-multimail/git-multimail/migrate-mailhook-config", line 66, in _check_old_config_exists > if name in old: > TypeError: argument of type 'Config' is not iterable > > Tested on 2.6 and 2.7 python versions. > > If you revert 09d0d5b92203f019763e43cef1e57f76f117d2b4 ("Get Python files to > pass pep8's tests.") there issue goes away. I understand that this is not the > right solution and I'm not the guru of python, so just let you know. Thanks for the bug report and for narrowing it down to the broken commit. I just pushed a fix to GitHub. Let me know if it works for you now. Elijah: your fix is also correct, but I didn't see it before I pushed my own solution. Sorry about that. Junio: you don't have to worry about any of this, because the commit that caused the breakage is not in your tree yet. Michael -- Michael Haggerty mhagger@alum.mit.edu ``` ## Azat Khuzhin, 2014-05-31 15:21 Subject: Re: git-multimail: migration: Config is not iterable Message-ID: <20140531151931.GJ27473@azat> URL: https://gitlist.dev/e/20140531151931.GJ27473%40azat In-Reply-To: <5389EE61.9060108@alum.mit.edu> ``` On Sat, May 31, 2014 at 04:59:45PM +0200, Michael Haggerty wrote: > On 05/29/2014 04:22 PM, Azat Khuzhin wrote: > > Using the latest version of git-multimail there is an issue with > > migration: > > > > $ ~azat/git-multimail/git-multimail/migrate-mailhook-config --overwrite > > Traceback (most recent call last): > > File "/home/azat/git-multimail/git-multimail/migrate-mailhook-config", line 271, in > > main(sys.argv[1:]) > > File "/home/azat/git-multimail/git-multimail/migrate-mailhook-config", line 268, in main > > migrate_config(strict=options.strict, retain=options.retain, overwrite=options.overwrite) > > File "/home/azat/git-multimail/git-multimail/migrate-mailhook-config", line 159, in migrate_config > > if not _check_old_config_exists(old): > > File "/home/azat/git-multimail/git-multimail/migrate-mailhook-config", line 66, in _check_old_config_exists > > if name in old: > > TypeError: argument of type 'Config' is not iterable > > > > Tested on 2.6 and 2.7 python versions. > > > > If you revert 09d0d5b92203f019763e43cef1e57f76f117d2b4 ("Get Python files to > > pass pep8's tests.") there issue goes away. I understand that this is not the > > right solution and I'm not the guru of python, so just let you know. > > Thanks for the bug report and for narrowing it down to the broken > commit. I just pushed a fix to GitHub. Let me know if it works for you > now. Yeah, it works, thanks! -- Respectfully Azat Khuzhin ```