# [PATCH] tests: turn off git-daemon tests if FIFOs are not available 2 messages from 2014-05-29 to 2014-05-29. Participants: Stepan Kasal, Jeff King. Thread: https://gitlist.dev/t/36783 ## Stepan Kasal, 2014-05-29 11:36 Subject: [PATCH] tests: turn off git-daemon tests if FIFOs are not available Message-ID: <20140529113614.GA24293@camelia.ucw.cz> URL: https://gitlist.dev/e/20140529113614.GA24293%40camelia.ucw.cz ``` Signed-off-by: Stepan Kasal --- Hi, mingw does not have FIFOs, so it cannot run git-daemon tests. Stepan t/lib-git-daemon.sh | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/t/lib-git-daemon.sh b/t/lib-git-daemon.sh index bc4b341..9b1271c 100644 --- a/t/lib-git-daemon.sh +++ b/t/lib-git-daemon.sh @@ -23,6 +23,11 @@ then test_done fi +if ! test_have_prereq PIPE +then + test_skip_or_die $GIT_TEST_GIT_DAEMON "file system does not support FIFOs" +fi + LIB_GIT_DAEMON_PORT=${LIB_GIT_DAEMON_PORT-${this_test#t}} GIT_DAEMON_PID= -- 1.9.2.msysgit.0.493.g4becbf6.dirty -- -- *** Please reply-to-all at all times *** *** (do not pretend to know who is subscribed and who is not) *** *** Please avoid top-posting. *** The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free. You received this message because you are subscribed to the Google Groups "msysGit" group. To post to this group, send email to msysgit@googlegroups.com To unsubscribe from this group, send email to msysgit+unsubscribe@googlegroups.com For more options, and view previous threads, visit this group at http://groups.google.com/group/msysgit?hl=en_US?hl=en --- You received this message because you are subscribed to the Google Groups "msysGit" group. To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. ``` ## Jeff King, 2014-05-29 15:57 Subject: Re: [PATCH] tests: turn off git-daemon tests if FIFOs are not available Message-ID: <20140529155710.GA3763@sigill.intra.peff.net> URL: https://gitlist.dev/e/20140529155710.GA3763%40sigill.intra.peff.net In-Reply-To: <20140529113614.GA24293@camelia.ucw.cz> ``` On Thu, May 29, 2014 at 01:36:14PM +0200, Stepan Kasal wrote: > Signed-off-by: Stepan Kasal > --- > > Hi, > mingw does not have FIFOs, so it cannot run git-daemon tests. Thanks. I took a peek at the mkfifo call here. It is used to make sure the daemon has started before we run the tests which depend on it. I suspect we could do something with a regular pipe, but the code would be rather tricky. Simply skipping the daemon tests is a reasonable compromise until somebody feels like trying to make it work without a fifo. -Peff -- -- *** Please reply-to-all at all times *** *** (do not pretend to know who is subscribed and who is not) *** *** Please avoid top-posting. *** The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free. You received this message because you are subscribed to the Google Groups "msysGit" group. To post to this group, send email to msysgit@googlegroups.com To unsubscribe from this group, send email to msysgit+unsubscribe@googlegroups.com For more options, and view previous threads, visit this group at http://groups.google.com/group/msysgit?hl=en_US?hl=en --- You received this message because you are subscribed to the Google Groups "msysGit" group. To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. ```