[PATCH] git-remote-testgit.sh: cleaned up the logic for setting the refspec variable

Elia Pinto· May 23, 2014, 16:17 UTC · lore

This patch makes the code more readable for setting the refspec variable

Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
---
 git-remote-testgit.sh |   14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

Show changes to git-remote-testgit.sh +8 −6

diff --git a/git-remote-testgit.sh b/git-remote-testgit.sh
index 1c006a0..fb8a003 100755
--- a/git-remote-testgit.sh
+++ b/git-remote-testgit.sh
@@ -4,18 +4,20 @@
 alias=$1
 url=$2
 
+if test -z "${GIT_REMOTE_TESTGIT_REFSPEC-notEmpty}"
+then
+	# only if it is explicitly set to an empty string...
+	prefix=refs
+else
+	prefix="refs/testgit/$alias"
+fi
 dir="$GIT_DIR/testgit/$alias"
-prefix="refs/testgit/$alias"
-
 default_refspec="refs/heads/*:${prefix}/heads/*"
-
 refspec="${GIT_REMOTE_TESTGIT_REFSPEC-$default_refspec}"
-
-test -z "$refspec" && prefix="refs"
+force=
 
 export GIT_DIR="$url/.git"
 
-force=
 
 mkdir -p "$dir"

-- 
1.7.10.4

patchgit-remote-testgit.sh: cleaned up the logic for setting the refspec variable