# Bash prompt "namespace" issue

2 messages from 2014-05-13 to 2014-05-13. Participants: szeder@ira.uka.de, Junio C Hamano.
Thread: https://gitlist.dev/t/36645

## szeder@ira.uka.de, 2014-05-13 06:18

Subject: Bash prompt "namespace" issue
Message-ID: <20140513081849.5dql886xw080ww88@webmail.informatik.kit.edu>
URL: https://gitlist.dev/e/20140513081849.5dql886xw080ww88%40webmail.informatik.kit.edu

```
Hi,

Commit 59d3924fb (prompt: fix missing file errors in zsh) added the  
helper function eread() to git-prompt.sh.  That function should be in  
the git "namespace", i.e. prefixed with __git_, otherwise it might  
collide with a function of the same name in the user's environment.

It's already in master and I don't have the means to send a patch  
fixing this ATM, sorry.

Best,
Gábor

```

## Junio C Hamano, 2014-05-13 18:52

Subject: Re: Bash prompt "namespace" issue
Message-ID: <xmqqoaz1o6je.fsf@gitster.dls.corp.google.com>
URL: https://gitlist.dev/e/xmqqoaz1o6je.fsf%40gitster.dls.corp.google.com
In-Reply-To: <20140513081849.5dql886xw080ww88@webmail.informatik.kit.edu>

```
szeder@ira.uka.de writes:

> Commit 59d3924fb (prompt: fix missing file errors in zsh) added the  
> helper function eread() to git-prompt.sh.  That function should be in  
> the git "namespace", i.e. prefixed with __git_, otherwise it might  
> collide with a function of the same name in the user's environment.
>
> It's already in master and I don't have the means to send a patch  
> fixing this ATM, sorry.

Thanks.  I think the patch Felipe posted to rename it to __git_eread
is a reasonable regression fix, so I'll queue it on top of the
problematic commit 59d3924f (prompt: fix missing file errors in zsh,
2014-04-11) and merge the result to 'master'.

```