# [PATCH] shell doc: remove stray "+" in example 3 messages from 2014-05-07 to 2014-05-08. Participants: Jonathan Nieder, Jeff King, Junio C Hamano. Thread: https://gitlist.dev/t/36603 ## Jonathan Nieder, 2014-05-07 23:44 Subject: [PATCH] shell doc: remove stray "+" in example Message-ID: <20140507234401.GY9218@google.com> URL: https://gitlist.dev/e/20140507234401.GY9218%40google.com ``` The git-shell(1) manpage says EXAMPLE To disable interactive logins, displaying a greeting instead: + $ chsh -s /usr/bin/git-shell $ mkdir $HOME/git-shell-commands [...] The stray "+" has been there ever since the example was added in v1.8.3-rc0~210^2 (shell: new no-interactive-login command to print a custom message, 2013-03-09). The "+" sign between paragraphs is needed in asciidoc to attach extra paragraphs to a list item but here it is not needed and ends up rendered as a literal "+". Remove it. A quick search with "grep -e '

+' /usr/share/doc/git/html/*.html" doesn't find any other instances of this problem. Signed-off-by: Jonathan Nieder --- Documentation/git-shell.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/git-shell.txt b/Documentation/git-shell.txt index c35051b..e4bdd22 100644 --- a/Documentation/git-shell.txt +++ b/Documentation/git-shell.txt @@ -66,7 +66,7 @@ EXAMPLE ------- To disable interactive logins, displaying a greeting instead: -+ + ---------------- $ chsh -s /usr/bin/git-shell $ mkdir $HOME/git-shell-commands -- 1.9.1.423.g4596e3a ``` ## Jeff King, 2014-05-08 04:04 Subject: Re: [PATCH] shell doc: remove stray "+" in example Message-ID: <20140508040438.GB26630@sigill.intra.peff.net> URL: https://gitlist.dev/e/20140508040438.GB26630%40sigill.intra.peff.net In-Reply-To: <20140507234401.GY9218@google.com> ``` On Wed, May 07, 2014 at 04:44:01PM -0700, Jonathan Nieder wrote: > The git-shell(1) manpage says > > EXAMPLE > To disable interactive logins, displaying a greeting > instead: > > + > > $ chsh -s /usr/bin/git-shell > $ mkdir $HOME/git-shell-commands > [...] > > The stray "+" has been there ever since the example was added in > v1.8.3-rc0~210^2 (shell: new no-interactive-login command to print a > custom message, 2013-03-09). The "+" sign between paragraphs is > needed in asciidoc to attach extra paragraphs to a list item but here > it is not needed and ends up rendered as a literal "+". Remove it. > > A quick search with "grep -e '

+' /usr/share/doc/git/html/*.html" > doesn't find any other instances of this problem. > > Signed-off-by: Jonathan Nieder Looks good to me. I suspect it was copied from another spot where the examples _were_ in a list (e.g., git-add's EXAMPLES section). Either way, your fix is the right thing to do. -Peff ``` ## Junio C Hamano, 2014-05-08 17:26 Subject: Re: [PATCH] shell doc: remove stray "+" in example Message-ID: URL: https://gitlist.dev/e/xmqqsiok41wu.fsf%40gitster.dls.corp.google.com In-Reply-To: <20140508040438.GB26630@sigill.intra.peff.net> ``` Jeff King writes: > On Wed, May 07, 2014 at 04:44:01PM -0700, Jonathan Nieder wrote: > >> The git-shell(1) manpage says >> >> EXAMPLE >> To disable interactive logins, displaying a greeting >> instead: >> >> + >> >> $ chsh -s /usr/bin/git-shell >> $ mkdir $HOME/git-shell-commands >> [...] >> >> The stray "+" has been there ever since the example was added in >> v1.8.3-rc0~210^2 (shell: new no-interactive-login command to print a >> custom message, 2013-03-09). The "+" sign between paragraphs is >> needed in asciidoc to attach extra paragraphs to a list item but here >> it is not needed and ends up rendered as a literal "+". Remove it. >> >> A quick search with "grep -e '

+' /usr/share/doc/git/html/*.html" >> doesn't find any other instances of this problem. >> >> Signed-off-by: Jonathan Nieder > > Looks good to me. I suspect it was copied from another spot where the > examples _were_ in a list (e.g., git-add's EXAMPLES section). Either > way, your fix is the right thing to do. Thanks, both. Looks good to me, too. ```