# [PATCH] builtin/tag.c: Add tag name to user message 2 messages from 2013-08-29 to 2014-05-07. Participants: Thorsten Glaser, Junio C Hamano. Thread: https://gitlist.dev/t/36595 ## Thorsten Glaser, 2013-08-29 22:03 Subject: [PATCH] builtin/tag.c: Add tag name to user message Message-ID: <201405070749.s477nvCL000897@herc.mirbsd.org> URL: https://gitlist.dev/e/201405070749.s477nvCL000897%40herc.mirbsd.org ``` Display the tag name about to be added to the user during interactive editing. Signed-off-by: Thorsten Glaser Signed-off-by: Richard Hartmann --- builtin/tag.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/builtin/tag.c b/builtin/tag.c index 6c7c6bd..8a7265b 100644 --- a/builtin/tag.c +++ b/builtin/tag.c @@ -278,11 +278,11 @@ static int do_sign(struct strbuf *buffer) } static const char tag_template[] = - N_("\nWrite a tag message\n" + N_("\nWrite a message for tag:\n %s\n" "Lines starting with '%c' will be ignored.\n"); static const char tag_template_nocleanup[] = - N_("\nWrite a tag message\n" + N_("\nWrite a message for tag:\n %s\n" "Lines starting with '%c' will be kept; you may remove them" " yourself if you want to.\n"); @@ -378,9 +378,9 @@ static void create_tag(const unsigned char *object, const char *tag, struct strbuf buf = STRBUF_INIT; strbuf_addch(&buf, '\n'); if (opt->cleanup_mode == CLEANUP_ALL) - strbuf_commented_addf(&buf, _(tag_template), comment_line_char); + strbuf_commented_addf(&buf, _(tag_template), tag, comment_line_char); else - strbuf_commented_addf(&buf, _(tag_template_nocleanup), comment_line_char); + strbuf_commented_addf(&buf, _(tag_template_nocleanup), tag, comment_line_char); write_or_die(fd, buf.buf, buf.len); strbuf_release(&buf); } -- 2.0.0.rc0 ``` ## Junio C Hamano, 2014-05-07 21:24 Subject: Re: [PATCH] builtin/tag.c: Add tag name to user message Message-ID: URL: https://gitlist.dev/e/xmqqy4yd704c.fsf%40gitster.dls.corp.google.com In-Reply-To: <201405070749.s477nvCL000897@herc.mirbsd.org> ``` Thorsten Glaser writes: > Display the tag name about to be added to the user during interactive > editing. > > Signed-off-by: Thorsten Glaser > Signed-off-by: Richard Hartmann > --- Sounds sensible from a first glance. Will queue; thanks. > builtin/tag.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/builtin/tag.c b/builtin/tag.c > index 6c7c6bd..8a7265b 100644 > --- a/builtin/tag.c > +++ b/builtin/tag.c > @@ -278,11 +278,11 @@ static int do_sign(struct strbuf *buffer) > } > > static const char tag_template[] = > - N_("\nWrite a tag message\n" > + N_("\nWrite a message for tag:\n %s\n" > "Lines starting with '%c' will be ignored.\n"); > > static const char tag_template_nocleanup[] = > - N_("\nWrite a tag message\n" > + N_("\nWrite a message for tag:\n %s\n" > "Lines starting with '%c' will be kept; you may remove them" > " yourself if you want to.\n"); > > @@ -378,9 +378,9 @@ static void create_tag(const unsigned char *object, const char *tag, > struct strbuf buf = STRBUF_INIT; > strbuf_addch(&buf, '\n'); > if (opt->cleanup_mode == CLEANUP_ALL) > - strbuf_commented_addf(&buf, _(tag_template), comment_line_char); > + strbuf_commented_addf(&buf, _(tag_template), tag, comment_line_char); > else > - strbuf_commented_addf(&buf, _(tag_template_nocleanup), comment_line_char); > + strbuf_commented_addf(&buf, _(tag_template_nocleanup), tag, comment_line_char); > write_or_die(fd, buf.buf, buf.len); > strbuf_release(&buf); > } ```