threads / patch / 3651

patchFix broken slot reuse when fetching alternates

Subject: [PATCH] Fix broken slot reuse when fetching alternates

## tl;dr

One message between Mar 15, 2006 and Mar 15, 2006. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Nick Hengeveld· Mar 15, 2006, 16:59 UTC · lore

When fetching alternates, http-fetch may reuse the slot to fetch non-http alternates if http-alternates does not exist. When doing so, it now needs to update the slot's finished status so run_active_slot waits for the non-http alternates request to finish.

Signed-off-by: Nick Hengeveld <nickh@reactrix.com>
---
 http-fetch.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
e0e27549c5cbc85639f7d329a8a900ca7243130c
Show changes to http-fetch.c +4 −0
diff --git a/http-fetch.c b/http-fetch.c
index 8fd9de0..7de818b 100644
--- a/http-fetch.c
+++ b/http-fetch.c
@@ -468,9 +468,13 @@ static void process_alternates_response(
 					 alt_req->url);
 			active_requests++;
 			slot->in_use = 1;
+			if (slot->finished != NULL)
+				(*slot->finished) = 0;
 			if (!start_active_slot(slot)) {
 				got_alternates = -1;
 				slot->in_use = 0;
+				if (slot->finished != NULL)
+					(*slot->finished) = 1;
 			}
 			return;
 		}
-- 
1.2.4.gea75-dirty

← back to recent threads