# [PATCH] gitk: switch to patch mode when searching for line origin

2 messages from 2014-04-05 to 2014-06-15. Participants: Max Kirillov, Paul Mackerras.
Thread: https://gitlist.dev/t/36351

## Max Kirillov, 2014-04-05 20:38

Subject: [PATCH] gitk: switch to patch mode when searching for line origin
Message-ID: <20140405203850.GA20967@wheezy.local>
URL: https://gitlist.dev/e/20140405203850.GA20967%40wheezy.local

```
If the "Show origin of this line" is started from tree mode,
it still shows the result in tree mode, which I suppose not
what user expects to see.
---
 gitk | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/gitk b/gitk
index 90764e8..5a99350 100755
--- a/gitk
+++ b/gitk
@@ -3870,7 +3870,7 @@ proc read_line_source {fd inst} {
 	    set id $nullid2
 	}
 	if {[commitinview $id $curview]} {
-	    selectline [rowofcommit $id] 1 [list $fname $lnum]
+	    selectline [rowofcommit $id] 1 [list $fname $lnum] 1
 	} else {
 	    error_popup [mc "That line comes from commit %s, \
 			     which is not in this view" [shortids $id]]
@@ -7161,7 +7161,7 @@ proc make_idmark {id} {
     $canv raise $t
 }
 
-proc selectline {l isnew {desired_loc {}}} {
+proc selectline {l isnew {desired_loc {}} {switch_to_patch 0}} {
     global canv ctext commitinfo selectedline
     global canvy0 linespc parents children curview
     global currentid sha1entry
@@ -7187,6 +7187,10 @@ proc selectline {l isnew {desired_loc {}}} {
 	setcanvscroll
     }
 
+    if {$cmitmode ne "patch" && $switch_to_patch} {
+        set cmitmode "patch"
+    }
+
     set y [expr {$canvy0 + $l * $linespc}]
     set ymax [lindex [$canv cget -scrollregion] 3]
     set ytop [expr {$y - $linespc - 1}]
-- 
1.8.5.2.421.g4cdf8d0

```

## Paul Mackerras, 2014-06-15 04:56

Subject: Re: [PATCH] gitk: switch to patch mode when searching for line origin
Message-ID: <20140615045611.GB21978@iris.ozlabs.ibm.com>
URL: https://gitlist.dev/e/20140615045611.GB21978%40iris.ozlabs.ibm.com
In-Reply-To: <20140405203850.GA20967@wheezy.local>

```
On Sat, Apr 05, 2014 at 11:38:50PM +0300, Max Kirillov wrote:
> If the "Show origin of this line" is started from tree mode,
> it still shows the result in tree mode, which I suppose not
> what user expects to see.

Thanks, applied.

Paul.

```