# [PATCH v4 1/2] diff-no-index.c: rename read_directory() 2 messages from 2014-03-19 to 2014-03-19. Participants: Andrei Dinu, Matthieu Moy. Thread: https://gitlist.dev/t/36229 ## Andrei Dinu, 2014-03-19 15:38 Subject: [PATCH v4 1/2] diff-no-index.c: rename read_directory() Message-ID: <1395243516-5753-1-git-send-email-mandrei.dinu@gmail.com> URL: https://gitlist.dev/e/1395243516-5753-1-git-send-email-mandrei.dinu%40gmail.com ``` Signed-off-by: Andrei Dinu --- I plan on applying to GSoc 2014 diff-no-index.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/diff-no-index.c b/diff-no-index.c index 8e10bff..5e4a76c 100644 --- a/diff-no-index.c +++ b/diff-no-index.c @@ -16,7 +16,7 @@ #include "builtin.h" #include "string-list.h" -static int read_directory(const char *path, struct string_list *list) +static int read_directory_path(const char *path, struct string_list *list) { DIR *dir; struct dirent *e; @@ -107,9 +107,9 @@ static int queue_diff(struct diff_options *o, int i1, i2, ret = 0; size_t len1 = 0, len2 = 0; - if (name1 && read_directory(name1, &p1)) + if (name1 && read_directory_path(name1, &p1)) return -1; - if (name2 && read_directory(name2, &p2)) { + if (name2 && read_directory_path(name2, &p2)) { string_list_clear(&p1, 0); return -1; } -- 1.7.9.5 ``` ## Matthieu Moy, 2014-03-19 17:47 Subject: Re: [PATCH v4 1/2] diff-no-index.c: rename read_directory() Message-ID: URL: https://gitlist.dev/e/vpqd2hidqsj.fsf%40anie.imag.fr In-Reply-To: <1395243516-5753-1-git-send-email-mandrei.dinu@gmail.com> ``` Andrei Dinu writes: > Signed-off-by: Andrei Dinu The commit message should explain why this is a good change. In general, the "why?" question is more important than the "what" (the reader can see from the patch that you renamed the function, but cannot guess why you did so). Also, when sending multiple patches, send them as a single thread. See for example: http://thread.gmane.org/gmane.comp.version-control.git/244441 In practice, call "git send-email" once, not once per patch. Try sending the patches to yourself first to avoid disturbing the list in case of user error. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ ```