threads / patch / 36179

patchgitk: Avoid issues with script path format

Subject: [PATCH] gitk: Avoid issues with script path format

## tl;dr

One message between Mar 16, 2014 and Mar 16, 2014. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Steven Penny· Mar 16, 2014, 06:12 UTC · lore
Tk’s "wish" for Windows can be built two ways
win   this provides a "wish" that uses GDI; it only understands Windows
      paths such as C:\foo\bar
unix  this provides a "wish" that uses X11; it understands Windows and Cygwin
      paths such as C:\foo\bar or /foo/bar

Some Cygwin users will prefer to use the "win" version, as it avoids the large X11 dependency. However Cygwin passes the path "/bin/gitk" or similar and the "win" version of "wish" will not understand this. However "wish" does understand STDIN. Options such as "--all" will still work using this method as well.

Signed-off-by: Steven Penny <svnpenn@gmail.com>
---
 gitk-git/gitk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Show changes to gitk-git/gitk +1 −1
diff --git a/gitk-git/gitk b/gitk-git/gitk
index 90764e8..64a125d 100755
--- a/gitk-git/gitk
+++ b/gitk-git/gitk
@@ -1,6 +1,6 @@
 #!/bin/sh
 # Tcl ignores the next line -*- tcl -*- \
-exec wish "$0" -- "$@"
+exec wish < "$0" -- "$@"
 
 # Copyright © 2005-2014 Paul Mackerras.  All rights reserved.
 # This program is free software; it may be used, copied, modified
-- 
1.8.5.2

← back to recent threads