threads / patch / 36156

patchmicroproject for GSOC

Subject: [PATCH] microproject for GSOC

## tl;dr

5 messages between Mar 14, 2014 and Mar 14, 2014. Diffs are folded; open one to read it.

replies: 4people: 2as markdown or json

ubuntu733· Mar 14, 2014, 16:42 UTC · lore
Apply for GSOC.The microprojects is rewriter diff-index.c
Signed-off-by: ubuntu733 <ubuntu2012@126.com>
---
 diff-no-index.c |   11 ++++++-----
 dir.h           |    3 ++-
 2 files changed, 8 insertions(+), 6 deletions(-)
Show changes to 2 files +8 −6

diff-no-index.c, dir.h

diff --git a/diff-no-index.c b/diff-no-index.c
index 8e10bff..91ece64 100644
--- a/diff-no-index.c
+++ b/diff-no-index.c
@@ -3,7 +3,7 @@
  * Copyright (c) 2007 by Johannes Schindelin
  * Copyright (c) 2008 by Junio C Hamano
  */
-
+#define REMOVE 1
 #include "cache.h"
 #include "color.h"
 #include "commit.h"
@@ -24,10 +24,11 @@ static int read_directory(const char *path, struct string_list *list)
 	if (!(dir = opendir(path)))
 		return error("Could not open directory %s", path);
 
-	while ((e = readdir(dir)))
-		if (strcmp(".", e->d_name) && strcmp("..", e->d_name))
-			string_list_insert(list, e->d_name);
-
+	while ((e = readdir(dir))) {
+		while(is_dot_or_dotdot(e->d_name))
+                      break;
+		string_list_insert(list, e->d_name);
+              }
 	closedir(dir);
 	return 0;
 }
diff --git a/dir.h b/dir.h
index 55e5345..1d68818 100644
--- a/dir.h
+++ b/dir.h
@@ -138,8 +138,9 @@ extern int match_pathspec(const struct pathspec *pathspec,
 extern int within_depth(const char *name, int namelen, int depth, int max_depth);
 
 extern int fill_directory(struct dir_struct *dir, const struct pathspec *pathspec);
+#ifndef REMOVE
 extern int read_directory(struct dir_struct *, const char *path, int len, const struct pathspec *pathspec);
-
+#endif
 extern int is_excluded_from_list(const char *pathname, int pathlen, const char *basename,
 				 int *dtype, struct exclude_list *el);
 struct dir_entry *dir_add_ignored(struct dir_struct *dir, const char *pathname, int len);

-- 
1.7.9.5
Matthieu Moy· Mar 14, 2014, 17:10 UTC · re: ubuntu733 · lore

Re: [PATCH] microproject for GSOC

Hi,

Welcome to the Git community, and welcome to the GSOC program. Below are some comments to give you a taste of what a review looks like on this list. Do take the comments seriously (they should be addressed), but don't take them badly: critic is meant to be constructive.

ubuntu733 <ubuntu2012@126.com> writes: ^^^^^^^^^

Please, use a real name when you contribute to Git.
> Apply for GSOC.The microprojects is rewriter diff-index.c

This part of your message will become the commit message (i.e. cast in stone forever in git.git's history). The point is not that you want to apply for GSOC, but what the patch does and more importantly why it does it.

> +#define REMOVE 1

If the code is to be removed, then remove it. That's why we use a version control system ;-).

Show 6 quoted lines
> -	while ((e = readdir(dir)))
> -		if (strcmp(".", e->d_name) && strcmp("..", e->d_name))
> -			string_list_insert(list, e->d_name);
> -
> +	while ((e = readdir(dir))) {
> +		while(is_dot_or_dotdot(e->d_name))
Missing space between "while" and "(".
> +                      break;
Broken indentation (indent with space).

This while (...) break; seems really weird to me: if the condition is false, then you exit the loop because it's a while loop, and if the condition is true, you exit the loop because of the break. Isn't that a no-op?

> +		string_list_insert(list, e->d_name);
> +              }
Broken indentation (misplaced }).
-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
沈承恩· Mar 14, 2014, 17:44 UTC · re: Matthieu Moy · lore

Re:Re: [PATCH] microproject for GSOC

Thank you for your comments.I will amend those issues .As a Chinese student,what name should I use?My Chinese name is ok? At 2014-03-15 01:10:57,"Matthieu Moy" <Matthieu.Moy@grenoble-inp.fr> wrote:

Show 50 quoted lines
>Hi,
>
>Welcome to the Git community, and welcome to the GSOC program. Below are
>some comments to give you a taste of what a review looks like on this
>list. Do take the comments seriously (they should be addressed), but
>don't take them badly: critic is meant to be constructive.
>
>ubuntu733 <ubuntu2012@126.com> writes:
>^^^^^^^^^
>
>Please, use a real name when you contribute to Git.
>
>> Apply for GSOC.The microprojects is rewriter diff-index.c
>
>This part of your message will become the commit message (i.e. cast in
>stone forever in git.git's history). The point is not that you want to
>apply for GSOC, but what the patch does and more importantly why it does
>it.
>
>> +#define REMOVE 1
>
>If the code is to be removed, then remove it. That's why we use a
>version control system ;-).
>
>> -	while ((e = readdir(dir)))
>> -		if (strcmp(".", e->d_name) && strcmp("..", e->d_name))
>> -			string_list_insert(list, e->d_name);
>> -
>> +	while ((e = readdir(dir))) {
>> +		while(is_dot_or_dotdot(e->d_name))
>
>Missing space between "while" and "(".
>
>> +                      break;
>
>Broken indentation (indent with space).
>
>This while (...) break; seems really weird to me: if the condition is
>false, then you exit the loop because it's a while loop, and if the
>condition is true, you exit the loop because of the break. Isn't that a
>no-op?
>
>> +		string_list_insert(list, e->d_name);
>> +              }
>
>Broken indentation (misplaced }).
>
>-- 
>Matthieu Moy
>http://www-verimag.imag.fr/~moy/
沈承恩· Mar 14, 2014, 18:13 UTC · re: Matthieu Moy · lore

Re:Re: [PATCH] microproject for GSOC

Thank you for your comments.I will amend those issues .As a Chinese student,what name should I use?My Chinese name is ok? I am very interest in Open source.What can I do to increase my chance? At 2014-03-15 01:10:57,"Matthieu Moy" <Matthieu.Moy@grenoble-inp.fr> wrote:

Show 50 quoted lines
>Hi,
>
>Welcome to the Git community, and welcome to the GSOC program. Below are
>some comments to give you a taste of what a review looks like on this
>list. Do take the comments seriously (they should be addressed), but
>don't take them badly: critic is meant to be constructive.
>
>ubuntu733 <ubuntu2012@126.com> writes:
>^^^^^^^^^
>
>Please, use a real name when you contribute to Git.
>
>> Apply for GSOC.The microprojects is rewriter diff-index.c
>
>This part of your message will become the commit message (i.e. cast in
>stone forever in git.git's history). The point is not that you want to
>apply for GSOC, but what the patch does and more importantly why it does
>it.
>
>> +#define REMOVE 1
>
>If the code is to be removed, then remove it. That's why we use a
>version control system ;-).
>
>> -	while ((e = readdir(dir)))
>> -		if (strcmp(".", e->d_name) && strcmp("..", e->d_name))
>> -			string_list_insert(list, e->d_name);
>> -
>> +	while ((e = readdir(dir))) {
>> +		while(is_dot_or_dotdot(e->d_name))
>
>Missing space between "while" and "(".
>
>> +                      break;
>
>Broken indentation (indent with space).
>
>This while (...) break; seems really weird to me: if the condition is
>false, then you exit the loop because it's a while loop, and if the
>condition is true, you exit the loop because of the break. Isn't that a
>no-op?
>
>> +		string_list_insert(list, e->d_name);
>> +              }
>
>Broken indentation (misplaced }).
>
>-- 
>Matthieu Moy
>http://www-verimag.imag.fr/~moy/
Matthieu Moy· Mar 14, 2014, 18:59 UTC · re: 沈承恩 · lore

Re: [PATCH] microproject for GSOC

沈承恩 <ubuntu2012@126.com> writes:
> Thank you for your comments.I will amend those issues .As a Chinese
> student,what name should I use?My Chinese name is ok?

I guess it is. The git.git history already has contribution from 张忠山 for example (I don't know if it is chineese, but it looks so from my French eyes).

> I am very interest in Open source.What can I do to increase my chance?

Interesting blog post to read: http://softwareswirl.blogspot.fr/2014/03/my-secret-tip-for-gsoc-success.html

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/

← back to recent threads