threads / patch / 36115

patchDocumentation/git-am: Document supported --patch-format options

Subject: [PATCH] Documentation/git-am: Document supported --patch-format options

## tl;dr

5 messages between Mar 11, 2014 and Mar 17, 2014. Diffs are folded; open one to read it.

replies: 4people: 2as markdown or json

Chris Packham· Mar 11, 2014, 03:51 UTC · lore

The --patch-format option has been supported for a while but it is not mentioned in the man page and the short help cannot tell the user what the supported formats are. Add the option to the man page along with the supported options.

Signed-off-by: Chris Packham <judge.packham@gmail.com>
---
I've not bothered to actually explain what the options mean. I'm not
sure if readers will care aside from just trying them until one works
(that's all I did when I had a patch that failed detection).
 Documentation/git-am.txt |   12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)
Show changes to Documentation/git-am.txt +9 −3
diff --git a/Documentation/git-am.txt b/Documentation/git-am.txt
index 54d8461..76bd359 100644
--- a/Documentation/git-am.txt
+++ b/Documentation/git-am.txt
@@ -12,9 +12,9 @@ SYNOPSIS
 'git am' [--signoff] [--keep] [--[no-]keep-cr] [--[no-]utf8]
 	 [--3way] [--interactive] [--committer-date-is-author-date]
 	 [--ignore-date] [--ignore-space-change | --ignore-whitespace]
-	 [--whitespace=<option>] [-C<n>] [-p<n>] [--directory=<dir>]
-	 [--exclude=<path>] [--include=<path>] [--reject] [-q | --quiet]
-	 [--[no-]scissors]
+	 [--whitespace=<option>] [-C<n>] [-p<n>] [--patch-format=<format>]
+	 [--directory=<dir>] [--exclude=<path>] [--include=<path>]
+	 [--reject] [-q | --quiet] [--[no-]scissors]
 	 [(<mbox> | <Maildir>)...]
 'git am' (--continue | --skip | --abort)
 
@@ -97,6 +97,12 @@ default.   You can use `--no-utf8` to override this.
 	program that applies
 	the patch.
 
+--patch-format::
+	By default the command will try to detect the patch format
+	automatically. This option allows the user to bypass the automatic
+	detection and specify the patch format that the patch(es) should be
+	intepreted as. Valid formats are mbox, stgit, stgit-series and hg.
+
 -i::
 --interactive::
 	Run interactively.
-- 
1.7.9.5
Chris Packham· Mar 16, 2014, 07:59 UTC · re: Chris Packham · lore

Re: [PATCH] Documentation/git-am: Document supported --patch-format options

On 11/03/14 16:51, Chris Packham wrote:
Show 45 quoted lines
> The --patch-format option has been supported for a while but it is not
> mentioned in the man page and the short help cannot tell the user what
> the supported formats are. Add the option to the man page along with the
> supported options.
> 
> Signed-off-by: Chris Packham <judge.packham@gmail.com>
> ---
> I've not bothered to actually explain what the options mean. I'm not
> sure if readers will care aside from just trying them until one works
> (that's all I did when I had a patch that failed detection).
> 
>  Documentation/git-am.txt |   12 +++++++++---
>  1 file changed, 9 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/git-am.txt b/Documentation/git-am.txt
> index 54d8461..76bd359 100644
> --- a/Documentation/git-am.txt
> +++ b/Documentation/git-am.txt
> @@ -12,9 +12,9 @@ SYNOPSIS
>  'git am' [--signoff] [--keep] [--[no-]keep-cr] [--[no-]utf8]
>  	 [--3way] [--interactive] [--committer-date-is-author-date]
>  	 [--ignore-date] [--ignore-space-change | --ignore-whitespace]
> -	 [--whitespace=<option>] [-C<n>] [-p<n>] [--directory=<dir>]
> -	 [--exclude=<path>] [--include=<path>] [--reject] [-q | --quiet]
> -	 [--[no-]scissors]
> +	 [--whitespace=<option>] [-C<n>] [-p<n>] [--patch-format=<format>]
> +	 [--directory=<dir>] [--exclude=<path>] [--include=<path>]
> +	 [--reject] [-q | --quiet] [--[no-]scissors]
>  	 [(<mbox> | <Maildir>)...]
>  'git am' (--continue | --skip | --abort)
>  
> @@ -97,6 +97,12 @@ default.   You can use `--no-utf8` to override this.
>  	program that applies
>  	the patch.
>  
> +--patch-format::
> +	By default the command will try to detect the patch format
> +	automatically. This option allows the user to bypass the automatic
> +	detection and specify the patch format that the patch(es) should be
> +	intepreted as. Valid formats are mbox, stgit, stgit-series and hg.
> +
>  -i::
>  --interactive::
>  	Run interactively.
> 
Ping?

Actually now that I have the patch in a MUA I see the a simple s/intepreted/interpreted/ fixup is required.

Chris Packham· Mar 17, 2014, 07:35 UTC · re: Junio C Hamano · lore

Re: [PATCH] Documentation/git-am: Document supported --patch-format options

On 17/03/14 19:39, Junio C Hamano wrote:
Show 6 quoted lines
> Chris Packham <judge.packham@gmail.com> writes:
> 
>> Ping?
> 
> Hasn't it been already cooking in 'next' for a few days?
> 

Indeed I think I missed a "What's cooking". Do you want me to submit a fixup for the spelling mistake?

Chris Packham· Mar 17, 2014, 07:50 UTC · re: Chris Packham · lore

[PATCH] fixup! Documentation/git-am: Document supported --patch-format options

--- On 17/03/14 20:35, Chris Packham wrote:> On 17/03/14 19:39, Junio C Hamano wrote:

Show 10 quoted lines
>> Chris Packham <judge.packham@gmail.com> writes:
>>
>>> Ping?
>>
>> Hasn't it been already cooking in 'next' for a few days?
>>
> 
> Indeed I think I missed a "What's cooking". Do you want me to submit a
> fixup for the spelling mistake?
> 
May as well just send it.
 Documentation/git-am.txt |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Show changes to Documentation/git-am.txt +1 −1
diff --git a/Documentation/git-am.txt b/Documentation/git-am.txt
index 76bd359..f8a7d0c 100644
--- a/Documentation/git-am.txt
+++ b/Documentation/git-am.txt
@@ -101,7 +101,7 @@ default.   You can use `--no-utf8` to override this.
 	By default the command will try to detect the patch format
 	automatically. This option allows the user to bypass the automatic
 	detection and specify the patch format that the patch(es) should be
-	intepreted as. Valid formats are mbox, stgit, stgit-series and hg.
+	interpreted as. Valid formats are mbox, stgit, stgit-series and hg.
 
 -i::
 --interactive::
-- 
1.7.9.5

← back to recent threads