threads / patch / 3607

patchcommon: parse 'email (name)' correctly

Subject: [stgit] [PATCH] common: parse 'email (name)' correctly

## tl;dr

One message between Mar 9, 2006 and Mar 9, 2006. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Sam Vilain· Mar 9, 2006, 05:29 UTC · lore
Currently only e-mails of the form "Name <email>" are accepted by
stgit import etc, however some people use "email (Name)".  Accept this
alternate form.
---
Note: the function just below it might need consideration, too.
 stgit/commands/common.py |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)
Show changes to stgit/commands/common.py +5 −2
diff --git a/stgit/commands/common.py b/stgit/commands/common.py
index 2985379..4bfa4dd 100644
--- a/stgit/commands/common.py
+++ b/stgit/commands/common.py
@@ -175,12 +175,15 @@ def push_patches(patches, check_merged =
 
 def name_email(address):
     """Return a tuple consisting of the name and email parsed from a
-    standard 'name <email>' string
+    standard 'name <email>' or 'email (name)' string
     """
     address = re.sub('[\\\\"]', '\\\\\g<0>', address)
     str_list = re.findall('^(.*)\s*<(.*)>\s*$', address)
     if not str_list:
-        raise CmdException, 'Incorrect "name <email>" string: %s' % address
+        str_list = re.findall('^(.*)\s*\((.*)\)\s*$', address)
+        if not str_list:
+            raise CmdException, 'Incorrect "name <email>"/"email
(name)" string: %s' % address
+        return ( str_list[0][1], str_list[0][0] )
 
     return str_list[0]

← back to recent threads