# [PATCH] git-bisect.sh: fix a few style issues 2 messages from 2014-03-04 to 2014-03-04. Participants: Jacopo Notarstefano, Junio C Hamano. Thread: https://gitlist.dev/t/36045 ## Jacopo Notarstefano, 2014-03-04 00:21 Subject: [PATCH] git-bisect.sh: fix a few style issues Message-ID: <1393892503-12765-1-git-send-email-jacopo.notarstefano@gmail.com> URL: https://gitlist.dev/e/1393892503-12765-1-git-send-email-jacopo.notarstefano%40gmail.com ``` Redirection operators should have a space before them, but not after them. Signed-off-by: Jacopo Notarstefano --- git-bisect.sh | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/git-bisect.sh b/git-bisect.sh index 73b4c14..af4d04c 100755 --- a/git-bisect.sh +++ b/git-bisect.sh @@ -365,7 +365,7 @@ bisect_reset() { } case "$#" in 0) branch=$(cat "$GIT_DIR/BISECT_START") ;; - 1) git rev-parse --quiet --verify "$1^{commit}" > /dev/null || { + 1) git rev-parse --quiet --verify "$1^{commit}" >/dev/null || { invalid="$1" die "$(eval_gettext "'\$invalid' is not a valid commit")" } @@ -458,13 +458,13 @@ exit code \$res from '\$command' is < 0 or >= 128" >&2 fi # We have to use a subshell because "bisect_state" can exit. - ( bisect_state $state > "$GIT_DIR/BISECT_RUN" ) + ( bisect_state $state >"$GIT_DIR/BISECT_RUN" ) res=$? cat "$GIT_DIR/BISECT_RUN" if sane_grep "first bad commit could be any of" "$GIT_DIR/BISECT_RUN" \ - > /dev/null + >/dev/null then gettextln "bisect run cannot continue any more" >&2 exit $res @@ -477,7 +477,7 @@ exit code \$res from '\$command' is < 0 or >= 128" >&2 exit $res fi - if sane_grep "is the first bad commit" "$GIT_DIR/BISECT_RUN" > /dev/null + if sane_grep "is the first bad commit" "$GIT_DIR/BISECT_RUN" >/dev/null then gettextln "bisect run success" exit 0; -- 1.9.0.1.g641f09f ``` ## Junio C Hamano, 2014-03-04 02:30 Subject: Re: [PATCH] git-bisect.sh: fix a few style issues Message-ID: URL: https://gitlist.dev/e/xmqqzjl6lmot.fsf%40gitster.dls.corp.google.com In-Reply-To: <1393892503-12765-1-git-send-email-jacopo.notarstefano@gmail.com> ``` Jacopo Notarstefano writes: > Redirection operators should have a space before them, but not after them. > > Signed-off-by: Jacopo Notarstefano > --- Looks obviously harmless ;-) Thanks. ```