# Help needed: Tests failed While replacing char array with strbuf in bulk-checkin.c 2 messages from 2014-03-03 to 2014-03-03. Participants: saikrishna.sripada, Eric Sunshine. Thread: https://gitlist.dev/t/36042 ## saikrishna.sripada, 2014-03-03 21:11 Subject: Help needed: Tests failed While replacing char array with strbuf in bulk-checkin.c Message-ID: URL: https://gitlist.dev/e/d7af2c2bcb07168ecddedf76ca776cd0%40students.iiit.ac.in ``` Hi , I am trying do complete the microproject 4, inorder to apply to GSOC. I have made the below changes: https://gist.github.com/anhsirksai/9334565 Post my changes compilation is succes in the source directory. But when I ran the tests[make in t/ directory] my tests are failing saying " free(): invalid pointer: 0x3630376532353636 *** ======= Backtrace: ========= /lib/x86_64-linux-gnu/libc.so.6(+0x7eb96)[0x2b5f3b540b96] /home/saikrishna/Desktop/libcloud-0.14.1/sai/git/git[0x4fb829] /home/saikrishna/Desktop/libcloud-0.14.1/sai/git/git[0x47d425] /home/saikrishna/Desktop/libcloud-0.14.1/sai/git/git[0x4064ad] /home/saikrishna/Desktop/libcloud-0.14.1/sai/git/git[0x405a04] /home/saikrishna/Desktop/libcloud-0.14.1/sai/git/git[0x404cbd] /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xed)[0x2b5f3b4e376d] /home/saikrishna/Desktop/libcloud-0.14.1/sai/git/git[0x405109] " Can some one please help me with the memory allacation and strbuf_release() Thanks, --sai krishna ``` ## Eric Sunshine, 2014-03-03 22:14 Subject: Re: Help needed: Tests failed While replacing char array with strbuf in bulk-checkin.c Message-ID: URL: https://gitlist.dev/e/CAPig%2BcTE7wtVpmjN%3Dp56JB6avL8n_JhDC6g5cAgGcmJQ8OVt5g%40mail.gmail.com In-Reply-To: ``` On Mon, Mar 3, 2014 at 4:11 PM, saikrishna.sripada wrote: > I am trying do complete the microproject 4, inorder to apply to GSOC. > I have made the below changes: > > https://gist.github.com/anhsirksai/9334565 > > Post my changes compilation is succes in the source directory. > But when I ran the tests[make in t/ directory] my tests are failing saying > > " > free(): invalid pointer: 0x3630376532353636 *** > ======= Backtrace: ========= > /lib/x86_64-linux-gnu/libc.so.6(+0x7eb96)[0x2b5f3b540b96] > /home/saikrishna/Desktop/libcloud-0.14.1/sai/git/git[0x4fb829] > /home/saikrishna/Desktop/libcloud-0.14.1/sai/git/git[0x47d425] > /home/saikrishna/Desktop/libcloud-0.14.1/sai/git/git[0x4064ad] > /home/saikrishna/Desktop/libcloud-0.14.1/sai/git/git[0x405a04] > /home/saikrishna/Desktop/libcloud-0.14.1/sai/git/git[0x404cbd] > /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xed)[0x2b5f3b4e376d] > /home/saikrishna/Desktop/libcloud-0.14.1/sai/git/git[0x405109] > " > > Can some one please help me with the memory allacation and strbuf_release() Read the microproject text carefully and _fully_. It provides the clue you need to understand the problem. Rewrite bulk-checkin.c:finish_bulk_checkin() to use a strbuf for handling packname, and explain why this is useful. Also check if the first argument of pack-write.c:finish_tmp_packfile() can be made const. If, after making a closer examination of the mentioned functions, the problem still eludes you, ask here again. ```