# [PATCH v5] branch.c: change install_branch_config() to use skip_prefix()

1 messages from 2014-03-03 to 2014-03-03. Participants: Guanglin Xu.
Thread: https://gitlist.dev/t/36031

## Guanglin Xu, 2014-03-03 09:15

Subject: [PATCH v5] branch.c: change install_branch_config() to use skip_prefix()
Message-ID: <1393838155-56591-1-git-send-email-mzguanglin@gmail.com>
URL: https://gitlist.dev/e/1393838155-56591-1-git-send-email-mzguanglin%40gmail.com

```
to avoid a magic code of 11.

Helped-by: Sun He <sunheeh...@gmail.com>
Helped-by: Eric Sunshine <sunsh...@sunshineco.com>
Helped-by: Jacopo Notarstefano <jaco...@gmail.com>

Signed-off-by: Guanglin Xu <mzguanglin@gmail.com>
---

This is an implementation of the idea#2 of GSoC 2014 microproject.

 branch.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/branch.c b/branch.c
index 723a36b..fae7715 100644
--- a/branch.c
+++ b/branch.c
@@ -49,8 +49,8 @@ static int should_setup_rebase(const char *origin)
 
 void install_branch_config(int flag, const char *local, const char *origin, const char *remote)
 {
-	const char *shortname = remote + 11;
-	int remote_is_branch = starts_with(remote, "refs/heads/");
+	const char *shortname = skip_prefix(remote ,"refs/heads/");
+	int remote_is_branch = !!shortname;
 	struct strbuf key = STRBUF_INIT;
 	int rebasing = should_setup_rebase(origin);
 
-- 
1.9.0

```